Repository navigation
[rocprofiler-systems] Add new secrets, update paths - #241
Merged
jbonnell-amd merged 3 commits intoAug 11, 2025
Merged
Conversation
Collaborator
Author
|
Containers were updated successfully from this PR: Other workflows are failing for now, we will fix those in separate PRs. |
jbonnell-amd
changed the title
dgaliffiAMD
reviewed
Aug 11, 2025
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD
approved these changes
Aug 11, 2025
jbonnell-amd
deleted the
rocprofiler-systems/update-containers-workflow
branch
August 11, 2025 18:31
systems-assistant Bot
pushed a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Aug 11, 2025
* Add new secrets, update paths * Remove old containers.yml workflow file * Update .github/workflows/rocprofiler-systems-containers.yml Co-authored-by: David Galiffi <David.Galiffi@amd.com> [rocm-systems] ROCm/rocm-systems#241 (commit 4eaf1fe)
jbonnell-amd
pushed a commit
that referenced
this pull request
Aug 11, 2025
jrmadsen
pushed a commit
that referenced
this pull request
Aug 12, 2025
Test is missing from rocm-7.0 stack because of a HIP version check. In these builds, hip_version.h is still reporting 6.5.0. This check was originally put in to skip the test on older versions of ROCm, which should no longer be required - For SWDEV-537718 Signed-off-by: David Galiffi <David.Galiffi@amd.com> [ROCm/rocprofiler-systems commit: 28bee27]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
[ROCm/clr commit: fa55557]
ammallya
pushed a commit
that referenced
this pull request
Nov 17, 2025
Improve Functional Test for - SetCheckPowerCap - TestPowerCapReadWrite --------- Signed-off-by: josnarlo <Joseph.Narlo@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Nov 18, 2025
Improve Functional Test for - SetCheckPowerCap - TestPowerCapReadWrite --------- Signed-off-by: josnarlo <Joseph.Narlo@amd.com> [ROCm/amdsmi commit: 30ebf19]
ammallya
pushed a commit
that referenced
this pull request
Nov 21, 2025
Improve Functional Test for - SetCheckPowerCap - TestPowerCapReadWrite --------- Signed-off-by: josnarlo <Joseph.Narlo@amd.com> [ROCm/amdsmi commit: 30ebf19]
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
[ROCm/rocshmem commit: 0fd8866]
dayatsin-amd
pushed a commit
that referenced
this pull request
Apr 7, 2026
ammallya
pushed a commit
that referenced
this pull request
Apr 9, 2026
ammallya
pushed a commit
that referenced
this pull request
Apr 9, 2026
[ROCm/hipFile commit: 396ce8f]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
rocprofiler-systems-containers.ymlworkflow is unable to run on the rocm-systems repo due to the docker login secrets not being present in the repo.Technical Details
Updated
rocprofiler-systems-containers.ymlworkflow to reference new secret values for login, as well as update the paths include on push to reference itself instead of the old workflow that is no longer running.Test Plan
Workflow should pass before merging.
Test Result
Submission Checklist