Skip to content

[rocprofiler-compute] Improve roofline logging for roofline.csv #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamessiddeley-amd merged 5 commits into from
Jan 2, 2026
Merged

[rocprofiler-compute] Improve roofline logging for roofline.csv #2390

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b09774a
enhanced roofline log output for graceful exit
jamessiddeley-amd Dec 18, 2025
48b9f29
Merge branch 'develop' of https://github.com/ROCm/rocm-systems into u…
jamessiddeley-amd Dec 19, 2025
59c147a
addressed comment, added block filtering
jamessiddeley-amd Dec 19, 2025
6d1fcce
ruff format
jamessiddeley-amd Dec 19, 2025
db8a5b0
Merge branch 'develop' into users/jamessiddeley-amd/graceful-roof-patch
jamessiddeley-amd Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions projects/rocprofiler-compute/src/rocprof_compute_analyze/analysis_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,10 +293,9 @@ def get_sysinfo_path(data_path: str) -> Optional[str]:
)
w.roofline_peaks = pd.DataFrame()
else:
console_error(
console_log(
"roofline",
f"Roofline analysis skipped: {error_msg}",
exit=False,
)
w.roofline_peaks = pd.DataFrame()
else:
Expand Down
20 changes: 8 additions & 12 deletions projects/rocprofiler-compute/src/utils/tty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,12 @@ def show_all(
if not csv_dir.exists():
csv_dir.mkdir()

# Check for valid roofline data once (used to skip roofline tables in the loop)
has_valid_roofline = any(
hasattr(workload, "roofline_peaks") and not workload.roofline_peaks.empty
for workload in runs.values()
)

for panel_id, panel in arch_configs.panel_configs.items():
# Skip panels that don't support baseline comparison
if len(args.path) > 1 and panel_id in config.HIDDEN_SECTIONS:
Expand All @@ -509,18 +515,8 @@ def show_all(
for data_source in panel["data source"]:
for table_type, table_config in data_source.items():
# Skip roofline tables (401, 402) if roofline data is invalid
if table_config["id"] in [401, 402]:
has_valid_roofline = any(
hasattr(workload, "roofline_peaks")
and not workload.roofline_peaks.empty
for workload in runs.values()
)
if not has_valid_roofline:
console_warning(
Comment thread
vedithal-amd marked this conversation as resolved.
Resolved
f"Not showing Roofline table {table_config['id']} "
"due to invalid roofline data."
)
continue
if table_config["id"] in [401, 402] and not has_valid_roofline:
continue

# Block-filter logic:
# - If analysis used --filter-metrics, ignore profiling block filters
Expand Down
Loading