[lubosz]

Motivation

This series improves building rocprofiler-sdk / rocprofv3 with system libraries.

• It fixes a bug in the CMake build when ROCPROFILER_BUILD_GLOG was off
• It adds the possibility to build with the system's yaml-cpp
• It fixes the build with fmt 12.1.0, keeping it backwards compatible with the currently submoduled fmt version
• It proposes updating the fmt submodule to 12.1.0

This series is the result of packaging rocprofv3 in Arch Linux.
See https://gitlab.archlinux.org/archlinux/packaging/packages/rocprofiler/-/merge_requests/3

Technical Details

Add option to use system yaml-cpp.

Adds ROCPROFILER_BUILD_YAML_CPP CMake variable, defaulting to ON, which keeps the previous behaviour as default.

This enables building with a system yaml-cpp.

Since the submodule uses yaml-cpp's master branch, set the required version to the latest release 0.8.0.

Inlcude CPack before calling it

This resolves a bug in the CMake code, which relied on the glog submodule to include CPack, which was included too late.

Resolves following CMake error when building with -D ROCPROFILER_BUILD_GLOG=OFF:

CMake Error at cmake/rocprofiler_config_packaging.cmake:124 (cpack_add_component_group):
  Unknown CMake command "cpack_add_component_group".
Call Stack (most recent call first):
  CMakeLists.txt:135 (include)

Fix build with fmt 12.1.0.

This enables building with fmt versions 12.1.0 and higher by including
the now required <fmt/ranges.h> header for fmt::join.

This change is backwards compatible with the current submodule version
of fmt which is an old main branch, 15 commits above 10.1.0.

Update fmt submodule to 12.1.0

This patch is optional and I can drop it if required.

This updates the fmt submodule to 12.1.0, which is now possible with the previous patch and a good opportunity to change the submodule to a release version. Currently it uses an old main branch, 15 commits above the 10.1.0 release.

Test Plan

I am able to rocprofiler-sdk with and without system libraries with this patch set.
Running a CI build should ensure the validity of this patch set.

Test Result

Works for me.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

[jrmadsen]

@lubosz Regarding:

Inlcude CPack before calling it

This resolves a bug in the CMake code, which relied on the glog submodule to include CPack, which was included too late.

Resolves following CMake error when building with -D ROCPROFILER_BUILD_GLOG=OFF:

CMake Error at cmake/rocprofiler_config_packaging.cmake:124 (cpack_add_component_group):
  Unknown CMake command "cpack_add_component_group".
Call Stack (most recent call first):
  CMakeLists.txt:135 (include)

I think what you actually want is include(CPackComponent) not include(CPack) before cpack_add_component_group because the file MUST end with include(CPack).

[lubosz]

@lubosz Regarding:

Inlcude CPack before calling it

This resolves a bug in the CMake code, which relied on the glog submodule to include CPack, which was included too late.
Resolves following CMake error when building with -D ROCPROFILER_BUILD_GLOG=OFF:

CMake Error at cmake/rocprofiler_config_packaging.cmake:124 (cpack_add_component_group):
  Unknown CMake command "cpack_add_component_group".
Call Stack (most recent call first):
  CMakeLists.txt:135 (include)

I think what you actually want is include(CPackComponent) not include(CPack) before cpack_add_component_group because the file MUST end with include(CPack).

Good catch! I have updated the patch.

[lubosz]

I rebased the branch onto current develop.
Some of my include fixes were already addresses by 36d9d33

I updated my patch so it adds the ones still remaining.

@jrmadsen What is missing to get this merged?

[Copilot]

Pull request overview

Improve rocprofiler-sdk/rocprofv3 builds when preferring system-provided dependencies (yaml-cpp, fmt) and fix a CMake packaging issue when glog is disabled.

Changes:

• Add ROCPROFILER_BUILD_YAML_CPP option to switch between vendored yaml-cpp submodule and system yaml-cpp (>= 0.8.0).
• Fix fmt 12.1.0+ compilation by including <fmt/ranges.h> where fmt::join/range formatting is used.
• Fix packaging configuration by explicitly including CPackComponent before using component-group macros; update fmt submodule to 12.1.0.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/counters/metrics.hpp	Add missing standard header include.
projects/rocprofiler-sdk/source/lib/python/rocpd/source/sql_generator.hpp	Include <fmt/ranges.h> to support fmt 12.1.0+ range utilities.
projects/rocprofiler-sdk/source/lib/output/sql/common.hpp	Include <fmt/ranges.h> to support fmt 12.1.0+ range utilities.
projects/rocprofiler-sdk/external/fmt	Update fmt submodule revision to 12.1.0.
projects/rocprofiler-sdk/external/CMakeLists.txt	Add switch to use system yaml-cpp or build vendored yaml-cpp submodule.
projects/rocprofiler-sdk/cmake/rocprofiler_options.cmake	Add ROCPROFILER_BUILD_YAML_CPP CMake option.
projects/rocprofiler-sdk/cmake/rocprofiler_config_packaging.cmake	Include CPackComponent explicitly to avoid missing macro errors.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.