-
Notifications
You must be signed in to change notification settings - Fork 294
[Rocprofiler-system]: Enable UCX Communication tracing #2306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1140d44
Enable UCX Communication tracing
sputhala-amd 73daacf
remove debug print and fix copyright
sputhala-amd 6a56465
Rebase with develop
sputhala-amd 8088807
Docker ucx package name fix
sputhala-amd 53402e5
Fix build errors and unit test logic
sputhala-amd 6f35221
Unit test segfault temp fix
sputhala-amd 22498b8
Remove UCX gtest unit tests and associated CMake configuration
sputhala-amd de3a287
Merge branch 'develop' into users/sputhala/ucx_tracing
sputhala-amd 1584473
Merge branch 'develop' into users/sputhala/ucx_tracing
dgaliffiAMD 4b0436a
Exclude UCX tests for MPICH
sputhala-amd f71dcda
Changelog modification
sputhala-amd 0c03bb6
Merge branch 'develop' into users/sputhala/ucx_tracing
sputhala-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # ------------------------------------------------------------------------------# | ||
| # | ||
| # Finds headers for UCX (Unified Communication X) | ||
| # | ||
| # UCX is a high-performance communication framework used as a transport layer | ||
| # for MPI and other communication libraries. This module locates UCX headers | ||
| # (ucp.h, uct.h) for tracing and interception purposes. | ||
| # | ||
| # ------------------------------------------------------------------------------# | ||
|
|
||
| include(FindPackageHandleStandardArgs) | ||
|
|
||
| # ----------------------------------------------------------------------------------------# | ||
|
|
||
| set(UCX_HEADERS_INCLUDE_DIR_INTERNAL | ||
| "${PROJECT_SOURCE_DIR}/source/lib/rocprof-sys/library/tpls/ucx" | ||
| CACHE PATH | ||
| "Path to internal UCX headers" | ||
| ) | ||
|
|
||
| # ----------------------------------------------------------------------------------------# | ||
| # Find UCX headers (ucp.h and uct.h are under ucx/ subdirectory) | ||
| find_path( | ||
| UCX_HEADERS_INCLUDE_DIR | ||
| NAMES ucp/api/ucp.h | ||
| PATHS /usr/include /usr/local/include /opt/ucx/include | ||
| ) | ||
|
|
||
| if(NOT EXISTS "${UCX_HEADERS_INCLUDE_DIR}") | ||
| rocprofiler_systems_message( | ||
| AUTHOR_WARNING | ||
| "UCX headers do not exist! Setting UCX_HEADERS_INCLUDE_DIR to internal directory: ${UCX_HEADERS_INCLUDE_DIR_INTERNAL}" | ||
| ) | ||
| set(UCX_HEADERS_INCLUDE_DIR | ||
| "${UCX_HEADERS_INCLUDE_DIR_INTERNAL}" | ||
| CACHE PATH | ||
| "Path to UCX headers" | ||
| FORCE | ||
| ) | ||
| else() | ||
| rocprofiler_systems_message(STATUS "UCX headers found: ${UCX_HEADERS_INCLUDE_DIR}") | ||
| endif() | ||
|
|
||
| mark_as_advanced(UCX_HEADERS_INCLUDE_DIR) | ||
|
|
||
| # ----------------------------------------------------------------------------------------# | ||
|
|
||
| find_package_handle_standard_args(UCX DEFAULT_MSG UCX_HEADERS_INCLUDE_DIR) | ||
|
|
||
| # ------------------------------------------------------------------------------# | ||
|
|
||
| if(UCX_FOUND) | ||
| add_library(roc::ucx-headers INTERFACE IMPORTED) | ||
| target_include_directories( | ||
| roc::ucx-headers | ||
| SYSTEM | ||
| INTERFACE ${UCX_HEADERS_INCLUDE_DIR} | ||
| ) | ||
| endif() | ||
|
|
||
| # ------------------------------------------------------------------------------# | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -225,6 +225,9 @@ get_use_pid(); | |
| bool& | ||
| get_use_mpip(); | ||
|
|
||
| bool& | ||
| get_use_ucx(); | ||
|
|
||
| bool | ||
| get_use_kokkosp(); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.