Skip to content
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions projects/amdsmi/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
FROM rocm/dev-ubuntu-22.04

# Set environment variables for build directories and package patterns
ENV BUILD_FOLDER=/home/amdsmi/build
ENV BUILD_FOLDER=/home/rocm-systems/projects/amdsmi/build
ENV DEB_BUILD="amd-smi-lib*99999-local_amd64.deb"
ENV DEB_BUILD_TEST="amd-smi-lib-tests*99999-local_amd64.deb"

Expand All @@ -16,11 +16,13 @@ RUN apt update && apt-get install -y git build-essential rpm pkg-config g++ pyth
RUN python3 -m pip install --upgrade pip setuptools && \
python3 -m pip install cmake virtualenv

# Clone the AMD SMI repository from GitHub
RUN git clone -b amd-mainline https://github.com/ROCm/amdsmi.git
# Clone the AMD SMI repository from GitHub using sparse checkout
RUN git clone --filter=blob:none --sparse -b develop https://github.com/ROCm/rocm-systems.git && \
cd rocm-systems && \
git sparse-checkout set projects/amdsmi

# Navigate to the amdsmi directory
WORKDIR /home/amdsmi
WORKDIR /home/rocm-systems/projects/amdsmi

# Build and Install AMDSMI
RUN rm -rf ${BUILD_FOLDER} && \
Expand Down
3 changes: 2 additions & 1 deletion projects/clr/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ CLR is a part of HIP runtime for the AMD platform.Please follow these details to

## Issue Discussion ##

Please use the [GitHub Issue](https://github.com/ROCm/clr/issues) tab to notify us of issues.
Please use the [rocm-systems Issues](https://github.com/ROCm/rocm-systems/issues) tab to notify us of issues. In the `rocm-systems` repo, issues
related to CLR should be labeled accordingly to ensure they receive the proper attention.

* Use your best judgement for issue creation. If your issue is already listed, upvote the issue and
comment or post to provide additional details, such as how you reproduced this issue.
Expand Down
4 changes: 2 additions & 2 deletions projects/clr/README-doc.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ If you need to build static clr library, `rocm-llvm-dev` package should be insta

- `cmake .. -DCLR_BUILD_HIP=ON -DHIP_COMMON_DIR=$HIP_COMMON_DIR -DHIPCC_BIN_DIR=$HIPCC_BIN_DIR`

- `HIP_COMMON_DIR` points to [HIP](https://github.com/ROCm/HIP)
- `HIP_COMMON_DIR` points to [HIP](https://github.com/ROCm/rocm-systems/tree/develop/projects/hip)

- `HIPCC_BIN_DIR` points to hipcc directory, if you have ROCm installed you can point it to `$ROCM_PATH/bin`

Expand All @@ -51,7 +51,7 @@ For detail instructions, please refer to [how to build HIP](https://rocm.docs.am

## Tests

`hip-tests` is a separate repository hosted at [hip-tests](https://github.com/ROCm/hip-tests).
`hip-tests` is a separate project hosted at [hip-tests](https://github.com/ROCm/rocm-systems/tree/develop/projects/hip-tests).

To run `hip-tests` please go to the repository and follow the steps.

Expand Down
3 changes: 2 additions & 1 deletion projects/hip/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ If you want to contribute to our documentation, refer to {doc}`Contribute to ROC

## Issue Discussion ##

Please use the [GitHub Issue](https://github.com/ROCm/HIP/issues) tab to notify us of issues.
Please use the [rocm-systems Issues](https://github.com/ROCm/rocm-systems/issues) tab to notify us of issues. In the `rocm-systems` repo, issues
related to HIP should be labeled accordingly to ensure they receive the proper attention.

* Use your best judgement for issue creation. If your issue is already listed, upvote the issue and
comment or post to provide additional details, such as how you reproduced this issue.
Expand Down
8 changes: 4 additions & 4 deletions projects/hip/docs/how-to/hip_runtime_api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ CUDA platform, it is only a thin layer over the CUDA runtime or Driver API.

- **CLR** contains source code for AMD's compute language runtimes: ``HIP`` and
``OpenCL™``. CLR includes the ``HIP`` implementation on the AMD
platform: `hipamd <https://github.com/ROCm/clr/tree/develop/hipamd>`_ and the
platform: `hipamd <https://github.com/ROCm/rocm-systems/tree/develop/projects/clr/hipamd>`_ and the
ROCm Compute Language Runtime (``rocclr``). ``rocclr`` is a
virtual device interface that enables the HIP runtime to interact with
different backends such as :doc:`ROCr <rocr-runtime:index>` on Linux or PAL on
Windows. CLR also includes the `OpenCL runtime <https://github.com/ROCm/clr/tree/develop/opencl>`_
Windows. CLR also includes the `OpenCL runtime <https://github.com/ROCm/rocm-systems/tree/develop/projects/clr/opencl>`_
implementation.
- The **CUDA runtime** is built on top of the CUDA driver API, which is a C API
with lower-level access to NVIDIA GPUs. For details about the CUDA driver and
Expand All @@ -33,7 +33,7 @@ the following figure:
.. note::

On NVIDIA platform HIP runtime API calls CUDA runtime or CUDA driver via
hipother interface. For more information, see the `hipother repository <https://github.com/ROCm/hipother>`_.
hipother interface. For more information, see the `hipother repository <https://github.com/ROCm/rocm-systems/tree/develop/projects/hipother>`_.

Here are the various HIP Runtime API high level functions:

Expand All @@ -46,4 +46,4 @@ Here are the various HIP Runtime API high level functions:
* :doc:`./hip_runtime_api/call_stack`
* :doc:`./hip_runtime_api/multi_device`
* :doc:`./hip_runtime_api/opengl_interop`
* :doc:`./hip_runtime_api/external_interop`
* :doc:`./hip_runtime_api/external_interop`
12 changes: 6 additions & 6 deletions projects/hip/docs/understand/amd_clr.rst
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ Project organization

CLR includes the following source code,

* ``hipamd`` - contains implementation of ``HIP`` language on the AMD platform. It is hosted at `clr/hipamd <https://github.com/ROCm/clr/tree/amd-staging/hipamd>`_.
* ``hipamd`` - contains implementation of ``HIP`` language on the AMD platform. It is hosted at `clr/hipamd <https://github.com/ROCm/rocm-systems/tree/develop/projects/clr/hipamd>`_.

* ``opencl`` - contains implementation of `OpenCL™ <https://www.khronos.org/opencl/>`_ on AMD platform. It is hosted at `clr/opencl <https://github.com/ROCm/clr/tree/amd-staging/opencl>`_.
* ``opencl`` - contains implementation of `OpenCL™ <https://www.khronos.org/opencl/>`_ on AMD platform. It is hosted at `clr/opencl <https://github.com/ROCm/rocm-systems/tree/develop/projects/clr//opencl>`_.

* ``rocclr`` - contains ROCm compute runtime used in `HIP` and `OpenCL™`. This is hosted at `clr/rocclr <https://github.com/ROCm/clr/tree/amd-staging/rocclr>`_.
* ``rocclr`` - contains ROCm compute runtime used in `HIP` and `OpenCL™`. This is hosted at `clr/rocclr <https://github.com/ROCm/rocm-systems/tree/develop/projects/clr/rocclr>`_.


How to build/install
Expand Down Expand Up @@ -52,7 +52,7 @@ Linux

cmake .. -DCLR_BUILD_HIP=ON -DHIP_COMMON_DIR=$HIP_COMMON_DIR

``HIP_COMMON_DIR`` points to `HIP <https://github.com/ROCm/HIP>`_.
``HIP_COMMON_DIR`` points to `HIP <https://github.com/ROCm/rocm-systems/tree/develop/projects/hip>`_.

* For ``OpenCL™``

Expand All @@ -71,12 +71,12 @@ For detail instructions, please refer to `build HIP <https://rocm.docs.amd.com/p
Test
-----

``hip-tests`` is a separate repository hosted at `hip-tests <https://github.com/ROCm/hip-tests>`_.
``hip-tests`` is a separate repository hosted at `hip-tests <https://github.com/ROCm/rocm-systems/tree/develop/projects/hip-tests>`_.

To run ``hip-tests`` please go to the repository and follow the steps.


Release notes
-------------

HIP provides release notes in CLR `change log <https://github.com/ROCm/clr/blob/amd-staging/CHANGELOG.md>`_, which has records of changes in each release.
HIP provides release notes in CLR `change log <https://github.com/ROCm/rocm-systems/blob/develop/projects/clr/CHANGELOG.md>`_, which has records of changes in each release.
2 changes: 1 addition & 1 deletion projects/hip/docs/what_is_hip.rst
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ HIP runtime API to the CUDA runtime API. The host-side contains mostly inlined
wrappers or even just preprocessor defines, with no additional overhead.
The device-side code is compiled with ``nvcc``, just like normal CUDA kernels,
and therefore one can expect the same performance as if directly coding in CUDA.
The CUDA specific headers can be found in the `hipother repository <https://github.com/ROCm/hipother>`_.
The CUDA specific headers can be found in the `hipother repository <https://github.com/ROCm/rocm-systems/tree/develop/projects/hipother>`_.

For further details, check :ref:`HIP Runtime API Reference <runtime_api_reference>`.

Expand Down
5 changes: 3 additions & 2 deletions projects/hipother/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ If you want to contribute to our documentation, refer to {doc}`Contribute to ROC

## Issue Discussion ##

Please use the [GitHub Issue](https://github.com/ROCm/hipother/issues) tab to notify us of issues.
Please use the [GitHub Issue](https://github.com/ROCm/rocm-systems/issues) tab to notify us of issues. In the `rocm-systems` repo, issues
Comment thread
randyh62 marked this conversation as resolved.
Resolved
related to `hipother` should be labeled accordingly to ensure they receive the proper attention.

* Use your best judgement for issue creation. If your issue is already listed, upvote the issue and
comment or post to provide additional details, such as how you reproduced this issue.
Expand Down Expand Up @@ -130,4 +131,4 @@ During code reviews, another developer will take a look through your proposed ch
needed), they may leave a comment. You can follow up and respond to the comment, and/or create comments of your own if you have questions or ideas.
When a modification request has been completed, the conversation thread about it will be marked as resolved.

To update the code in your PR (eg. in response to a code review discussion), you can simply push another commit to the branch used in your pull request.
To update the code in your PR (eg. in response to a code review discussion), you can simply push another commit to the branch used in your pull request.
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Prerequisites

sudo apt install libelf-dev g++

- A compatible version of the ``libhsakmt`` library and the ``hsakmt.h`` header file. Obtain the latest version of these files from the `ROCT-Thunk-Interface repository <https://github.com/ROCm/ROCT-Thunk-Interface>`_.
- A compatible version of the ``libhsakmt`` library and the ``hsakmt.h`` header file. Obtain the latest version of these files from `ROCR-Runtime/libhsakmt <https://github.com/ROCm/rocm-systems/tree/develop/projects/rocr-runtime/libhsakmt>`_.

- Install ``xxd``.

Expand Down
Loading