Skip to content

Disable inline symbol visibility #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
systems-assistant wants to merge 8 commits into from
Closed

Disable inline symbol visibility #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d5ec0db
Hide visibility of inlines
jrmadsen Jun 26, 2025
ba0af2a
Fix ROCPROFILER_REGISTER_COMPUTE_VERSION_4
jrmadsen Jun 26, 2025
73047bb
Update VERSION to 0.5.1
jrmadsen Jun 26, 2025
e4b4dcb
Fix formatting workflows
jrmadsen Jun 26, 2025
43e66db
remove sudo
jrmadsen Jun 26, 2025
8e4286e
Resolving merge conflicts
jayhawk-commits Aug 5, 2025
0b385f3
Merge commit '8e4286e9984680311108cc32e6c0c5f9363a0834' into import/d…
systems-assistant[bot] Aug 5, 2025
a98c5d5
Merge branch 'develop' of https://github.com/ROCm/rocm-systems into i…
jrmadsen Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/rocprofiler-register/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ include(rocprofiler_register_config_interfaces) # configure interface libraries

set(CMAKE_C_VISIBILITY_PRESET "hidden")
set(CMAKE_CXX_VISIBILITY_PRESET "hidden")
set(CMAKE_VISIBILITY_INLINES_HIDDEN OFF)
set(CMAKE_VISIBILITY_INLINES_HIDDEN ON)
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR}")
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR}")
Expand Down
2 changes: 1 addition & 1 deletion projects/rocprofiler-register/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.5.0
0.5.1
4 changes: 2 additions & 2 deletions projects/rocprofiler-register/source/include/rocprofiler-register/rocprofiler-register.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@ rocprofiler_register_iterate_registration_info(
/// @brief Helper macro for users to generate versioning int expected by
/// rocprofiler-register when the library maintains a major, minor, patch, and tweak
/// version numbers
#define ROCPROFILER_REGISTER_COMPUTE_VERSION_3( \
MAJOR_VERSION, MINOR_VERSION, PATCH_VERSION) \
#define ROCPROFILER_REGISTER_COMPUTE_VERSION_4( \
MAJOR_VERSION, MINOR_VERSION, PATCH_VERSION, TWEAK_VERSION) \
(ROCPROFILER_REGISTER_COMPUTE_VERSION_2(MAJOR_VERSION, MINOR_VERSION) + \
(PATCH_VERSION))

Expand Down