Repository navigation
Handle cpu name having colons - #2155
Merged
mcrnobrn-amd merged 3 commits intoDec 11, 2025
Merged
Conversation
mcrnobrn-amd
force-pushed
the
users/mcrnobrn-amd/agent-model-name-colon-parsing
branch
from
December 3, 2025 08:39
a80944a to
c61a546
Compare
yhuiYH
reviewed
Dec 3, 2025
yhuiYH
reviewed
Dec 3, 2025
mcrnobrn-amd
force-pushed
the
users/mcrnobrn-amd/agent-model-name-colon-parsing
branch
from
December 4, 2025 00:40
c61a546 to
47f74fa
Compare
yhuiYH
approved these changes
Dec 9, 2025
yhuiYH
left a comment
yhuiYH
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thx for unit test Gopesh.
bgopesh
approved these changes
Dec 9, 2025
Contributor
|
Not sure why the Continuous Integration tests are failing. Holding merge until we know the CI tests are run. Tests are passing locally. |
yhuiYH
force-pushed
the
users/mcrnobrn-amd/agent-model-name-colon-parsing
branch
from
December 10, 2025 02:36
fa44bec to
11ac831
Compare
mcrnobrn-amd
deleted the
users/mcrnobrn-amd/agent-model-name-colon-parsing
branch
December 11, 2025 15:36
systems-assistant Bot
pushed a commit
to ROCm/rocprofiler-sdk
that referenced
this pull request
Dec 11, 2025
* Handle cpu name having colons * Adding tests to verify * clang-format fix [rocm-systems] ROCm/rocm-systems#2155 (commit 7b2f68e)
xuchen-amd
pushed a commit
that referenced
this pull request
Dec 16, 2025
* Handle cpu name having colons * Adding tests to verify * clang-format fix --------- Co-authored-by: bgopesh <gopesh.bhardwaj@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I was looking into SWDEV-559466 and found the root of the problem to be the lack of agent data (checked by Perfetto generation tests) on certain machines.
Technical Details
The data from
/proc/cpuinfosometimes includes model names that contain a colon and this was mishandled by the function.JIRA ID
Resolves SWDEV-559466
Test Plan
Run
ctest -R rocprofv3-test-rocpd-scratch*.Test Result
On the target environment there is a different issue causing related tests to fail. It is documented under SWDEV-534891.