Repository navigation
Conversation
ethtrinh
force-pushed
the
users/ethtrinh/null
branch
from
November 11, 2025 21:06
bde1bad to
d5b0de2
Compare
jamessiddeley-amd
pushed a commit
that referenced
this pull request
Dec 11, 2025
mch
pushed a commit
that referenced
this pull request
Jun 22, 2026
…er processing This MR syncs GitHub PR #[1806](NVIDIA/nccl#1806) by @andrewjcg. **Original Description:** Use `-MM` instead of `-M` in header/include tracking, so avoid potentially excessive `realpath` calls in some builds. Sync GitHub PR #1806: Ignore system headers in include/header processing Original PR by andrewjcg Use `-MM` instead of `-M` in header/include tracking, so avoid potentially excessive `realpath` calls in some builds. Files modified: src/Makefile, src/device/Makefile Synced from GitHub PR: NVIDIA/nccl#1806 Signed-off-by: Xiaofan Li <xiaofanl@nvidia.com> Mirrored-from: d73e363ddbf0f4fd49fa271346daf3bfdef93ad2
1 task
PedramAlizadeh
added a commit
that referenced
this pull request
Oct 14, 2026
NCCL PR #1806 dropped system headers from include tracking so the device DEPENDS realpath loop does not walk libc/HIP trees. Scan the src Makefiles in the host-test guards phase so a revert to -M fails CI. ## Motivation NCCL 2.30.7 switched Makefile include tracking from -M to -MM so system headers are not realpath’d during depgen. That change is already on develop; this PR only guards it against a silent revert. ## Technical Details src/test_makefile_depflags.py requires -MM/-MMD on the dep recipes in src/Makefile, src/device/Makefile, and src/diagnostics/device/Makefile, and rejects -M/-MD. Host-test CI runs it via run_host_tests.sh guards. The ctest registration is local-only. ## Issue Tracking JIRA ID: AICOMRCCL-1848 ## Test Plan Run python3 projects/rccl/src/test_makefile_depflags.py -v and confirm a -MM → -M revert fails. After push, check that the host-unit-test job runs the scan. ## Test Result All 6 local cases passed, and a -M mutation failed as expected. GPU / TheRock jobs were not run; they do not execute this script. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove warning for converting non-pointer type from NULL
Technical Details
Changed NULL to 0.
They are equivalent but integer does not cause conversion warning.
Test Plan
Compile hip-test
Test Result
Compiles with no warnings
Submission Checklist