Repository navigation
SWDEV-558839 - Implement hipMemPrefetchBatchAsync API - #1626
Merged
Merged
Conversation
github-actions
Bot
added
project: clr
project: hip
project: hipother
project: hip-tests
labels
marandje
force-pushed
the
users/marandje/prefetch_batch
branch
from
November 3, 2025 15:16
833c88a to
d2a330a
Compare
marandje
marked this pull request as ready for review
November 3, 2025 15:16
marandje
force-pushed
the
users/marandje/prefetch_batch
branch
2 times, most recently
from
November 4, 2025 08:48
36647fd to
b5bb605
Compare
AidanBeltonS
reviewed
Nov 4, 2025
AidanBeltonS
left a comment
AidanBeltonS
left a comment
Contributor
There was a problem hiding this comment.
Implementation looks good. Thanks! Some comments/questions.
I think you may also need some changes to rocprofiler to prevent breaks, see Sebastians changes in #1221
AidanBeltonS
approved these changes
Nov 6, 2025
AidanBeltonS
left a comment
AidanBeltonS
left a comment
Contributor
There was a problem hiding this comment.
Comments addressed, LGTM!
marandje
force-pushed
the
users/marandje/prefetch_batch
branch
3 times, most recently
from
November 20, 2025 22:09
9ad4b0b to
9eb377a
Compare
ammallya
pushed a commit
that referenced
this pull request
Jan 22, 2026
…peed (#1626) * Fixed parsing of env var lists which were overwriting the mutable env var string and polluting future parses. * Fixed all tests to obey UT_DATATYPES and UT_REDOPS filters. * Allow tests to bail early via `GTEST_SKIP` if UT_DATATYPES or UT_REDOPS filters give a test size of zero. This allows tests to run much faster with filters on. * Wrapped the support checks in helper functions on `TestBed`. [ROCm/rccl commit: 18e9ad9]
marandje
force-pushed
the
users/marandje/prefetch_batch
branch
5 times, most recently
from
February 3, 2026 09:43
f46b73b to
7e5b834
Compare
marandje
force-pushed
the
users/marandje/prefetch_batch
branch
2 times, most recently
from
February 10, 2026 09:11
0ede9bb to
f83b143
Compare
marandje
force-pushed
the
users/marandje/prefetch_batch
branch
2 times, most recently
from
February 18, 2026 09:36
00291b3 to
6e33e61
Compare
marandje
force-pushed
the
users/marandje/prefetch_batch
branch
from
February 23, 2026 09:11
6e33e61 to
e7a63bd
Compare
marandje
force-pushed
the
users/marandje/prefetch_batch
branch
4 times, most recently
from
February 27, 2026 14:27
27f2cd6 to
4ae3fea
Compare
marandje
force-pushed
the
users/marandje/prefetch_batch
branch
9 times, most recently
from
March 10, 2026 14:37
8ea1fb9 to
d5f89b8
Compare
venkat1361
approved these changes
Apr 2, 2026
venkat1361
left a comment
venkat1361
left a comment
Contributor
There was a problem hiding this comment.
rocprofiler-sdk changes looks good
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add hipMemPrefetchBatchAsync api in parity with cuMemPrefetchBatchAsync from cuda v13.0
Technical Details
Test Plan
Verify parameter validation, successful batch prefetching to multiple locations, compatibility with both managed and device memory...
Test Result
All validation and functional tests pass with correct asynchronous prefetch behavior and proper error handling.
Submission Checklist