SWDEV-563777 - fix warnings related to inconsistent overrides#1625
Merged
Conversation
github-actions
Bot
added
the
github actions
sluzynsk-amd
force-pushed
the
users/sluzynsk-amd/SWDEV-563777
branch
from
c397a0f to
90d6f35
Compare
gandryey
approved these changes
Nov 3, 2025
AidanBeltonS
approved these changes
Nov 3, 2025
sluzynsk-amd
force-pushed
the
users/sluzynsk-amd/SWDEV-563777
branch
2 times, most recently
from
ea733b8 to
7560d38
Compare
sluzynsk-amd
force-pushed
the
users/sluzynsk-amd/SWDEV-563777
branch
2 times, most recently
from
5576fe5 to
3b7b538
Compare
sluzynsk-amd
force-pushed
the
users/sluzynsk-amd/SWDEV-563777
branch
3 times, most recently
from
9239125 to
81c5dd7
Compare
This patch adds missing override keywords. Fixes this class of warnings. Signed-off-by: Sebastian Luzynski <Sebastian.Luzynski@amd.com>
sluzynsk-amd
force-pushed
the
users/sluzynsk-amd/SWDEV-563777
branch
from
81c5dd7 to
71513e7
Compare
systems-assistant Bot
pushed a commit
to ROCm/clr
that referenced
this pull request
Nov 24, 2025
(#1625) This patch adds missing override keywords. Fixes this class of warnings. Signed-off-by: Sebastian Luzynski <Sebastian.Luzynski@amd.com> [rocm-systems] ROCm/rocm-systems#1625 (commit 2cf9faa)
systems-assistant Bot
pushed a commit
to ROCm/hip
that referenced
this pull request
Nov 24, 2025
(#1625) This patch adds missing override keywords. Fixes this class of warnings. Signed-off-by: Sebastian Luzynski <Sebastian.Luzynski@amd.com> [rocm-systems] ROCm/rocm-systems#1625 (commit 2cf9faa)
jamessiddeley-amd
pushed a commit
that referenced
this pull request
Dec 11, 2025
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.18.1 to 1.18.2. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.18.1...v1.18.2) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-version: 1.18.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ammallya
pushed a commit
that referenced
this pull request
Jan 22, 2026
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.18.1 to 1.18.2. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.18.1...v1.18.2) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-version: 1.18.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [ROCm/rccl commit: b6d97a6]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds missing override keywords. Fixes this class of warnings.
Motivation
During clr build clang reports lots of warnings. This PR fixes warnings related to inconsistent override rules
Technical Details
Adds missing
overridekeywords to methods that override virtual methods from parent classTest Plan
Doesn't apply
Test Result
Doesn't apply
Submission Checklist