Skip to content

feat(rocprofiler-sdk): replay only dispatches the kernel filters select - #15269

Draft
MythreyaK wants to merge 1 commit into
developfrom
users/mkuriche/kernel-replay-filter
Draft

MythreyaK wants to merge 1 commit into
developfrom
users/mkuriche/kernel-replay-filter

Conversation

@MythreyaK

@MythreyaK MythreyaK commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Motivation

Honor kernel filtering with kernel replay

Technical Details

With --replay-mode kernel, the --kernel-include-regex, --kernel-exclude-regex and --kernel-iteration-range filters now also choose which dispatches are replayed. The others run once, without counters, instead of once per counter group. For example, with --kernel-include-regex '^Cijk_' each GEMM is replayed but the memsets around it run once.

The pass-count callback asks the filters first, so each launch still counts once toward the iteration range, and the answer is reused for the rest of that dispatch. It is keyed by dispatch id because graph and multi-packet dispatches skip the CONFIG callback that resets it.

Issue Tracking

Test Plan

Test this with both kernel iteration selection and regex filtering enabled, or one of them enabled.

Test Result

  • Test with iteration range
  • Test with regex-matching
  • Test with both

Submission Checklist

With --replay-mode kernel, the --kernel-include-regex,
--kernel-exclude-regex and --kernel-iteration-range filters now also
choose which dispatches are replayed. The others run once, without
counters, instead of once per counter group. For example, with
--kernel-include-regex '^Cijk_' each GEMM is replayed but the memsets
around it run once.

The pass-count callback asks the filters first, so each launch still
counts once toward the iteration range, and the answer is reused for
the rest of that dispatch. It is keyed by dispatch id because graph and
multi-packet dispatches skip the CONFIG callback that resets it.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation project: rocprofiler-sdk labels Nov 6, 2026
@therock-pr-bot

therock-pr-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocprofiler-sdk/source/bin/rocprofv3.py, projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/tool.cpp, projects/rocprofiler-sdk/tests/rocprofv3/kernel-replay/validate.py; no test file found
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant