Repository navigation
rocr-debug-agent: Use __scoped_atomic_load_n in sigquit_resume test - #15212
Merged
lumachad merged 1 commit intoNov 6, 2026
Merged
Conversation
__hip_atomic_load is deprecated and triggers a -Whip-deprecated-builtins warning. Switch to __scoped_atomic_load_n with __MEMORY_SCOPE_SYSTEM, which has the same semantics. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
lancesix
approved these changes
Nov 6, 2026
lumachad
deleted the
users/lumachad/rocr-debug-agent/hip_atomic_load_deprecate
branch
November 6, 2026 14:39
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Building the rocr-debug-agent tests emits a
-Whip-deprecated-builtinswarning:Technical Details
Replace
__hip_atomic_load (..., __HIP_MEMORY_SCOPE_SYSTEM)with__scoped_atomic_load_n (..., __MEMORY_SCOPE_SYSTEM)intest/sigquit_resume.cpp, as the compiler suggests. This was the only use of the deprecated builtins in rocr-debug-agent.Issue Tracking
N/A
Test Plan
Rebuild the rocr-debug-agent tests and confirm the warning is gone.
Test Result
Not yet run.
Submission Checklist
🤖 Generated with Claude Code