Skip to content

rocr-debug-agent: Use __scoped_atomic_load_n in sigquit_resume test - #15212

Merged
lumachad merged 1 commit into
developfrom
users/lumachad/rocr-debug-agent/hip_atomic_load_deprecate
Nov 6, 2026
Merged

lumachad merged 1 commit into
developfrom
users/lumachad/rocr-debug-agent/hip_atomic_load_deprecate

Conversation

@lumachad

@lumachad lumachad commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Motivation

Building the rocr-debug-agent tests emits a -Whip-deprecated-builtins warning:

test/sigquit_resume.cpp:44:10: warning: builtin __hip_atomic_load is deprecated; use __scoped_atomic_load_n instead

Technical Details

Replace __hip_atomic_load (..., __HIP_MEMORY_SCOPE_SYSTEM) with __scoped_atomic_load_n (..., __MEMORY_SCOPE_SYSTEM) in test/sigquit_resume.cpp, as the compiler suggests. This was the only use of the deprecated builtins in rocr-debug-agent.

Issue Tracking

N/A

Test Plan

Rebuild the rocr-debug-agent tests and confirm the warning is gone.

Test Result

Not yet run.

Submission Checklist

🤖 Generated with Claude Code

__hip_atomic_load is deprecated and triggers a
-Whip-deprecated-builtins warning.  Switch to __scoped_atomic_load_n
with __MEMORY_SCOPE_SYSTEM, which has the same semantics.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@lumachad
lumachad marked this pull request as ready for review November 6, 2026 11:56
@lumachad
lumachad requested a review from a team as a code owner November 6, 2026 11:56
@therock-pr-bot

therock-pr-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocr-debug-agent/test/sigquit_resume.cpp; no test file found
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@lumachad
lumachad merged commit 912a5fb into develop Nov 6, 2026
103 of 111 checks passed
@lumachad
lumachad deleted the users/lumachad/rocr-debug-agent/hip_atomic_load_deprecate branch November 6, 2026 14:39
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants