Repository navigation
[rocjitsu] Cover oversized register region copies - #15121
Merged
IanWood1 merged 1 commit intoNov 5, 2026
Merged
Conversation
Add a full-byte oversized-copy regression so partial-byte rejection cannot mask a missing capacity guard. Clarify the register-access failure contracts requested in the post-merge review of #14499. Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the regression-test and documentation changes.
No open issues 🎉
What changed in this PR
Adds regression coverage for oversized register-region copies in rocjitsu, supporting the exception-reduction work in #10239 and following up on #14499. Production behavior is unchanged.
Changes:
- Tests that copying a one-register wave64 region into a 65-word destination fails, retains the
InvalidRegisterAccessdiagnostic, and leaves the destination unchanged. - Clarifies existing failure behavior in the
VgprReadRegion::lanesandexecute_instructiondocumentation.
| File | Description |
|---|---|
emulation/rocjitsu/tests/register_access_test.cpp |
Adds the oversized-copy regression test. |
emulation/rocjitsu/lib/rocjitsu/src/rocjitsu/vm/amdgpu/register_access.h |
Documents partial-byte rejection by lanes. |
emulation/rocjitsu/lib/rocjitsu/src/rocjitsu/vm/amdgpu/compute_unit.h |
Documents register-access failures from execute_instruction. |
Review effort: Balanced
IanWood1
deleted the
users/IanWood1/rocjitsu-register-access-copy-bounds
branch
November 5, 2026 20:33
Contributor
rocjitsu post-commit fuzz passedThe 32-worker multiplexer campaigns for commit
|
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing oversized-copy regression from the post-merge review of #14499. Copying a full-byte, one-register wave64 region into a 65-word destination must return failure, retain the
InvalidRegisterAccessdiagnostic, and leave the destination unchanged. Also clarify register-access failures inexecute_instructionand partial-byte rejection inVgprReadRegion::lanes.Validated with a RelWithDebInfo wrapper build, all 63 register-access tests, and the changed-file pre-commit checks. Removing only the size guard makes the new regression fail; restoring it returns the suite to passing. Part of #10239.