Skip to content

[rocjitsu][plugin] Have report_routed_access respect 0 mask - #15044

Merged
accauble merged 2 commits into
developfrom
users/accauble/rj-scalar-routed-access-mask
Nov 6, 2026
Merged

accauble merged 2 commits into
developfrom
users/accauble/rj-scalar-routed-access-mask

Conversation

@accauble

@accauble accauble commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Motivation

Found by @kuhar in PR #14972. report_routed_access in ComputeUnitCore reported valid and requested lane masks as "1" even when the whole operation was masked. This updates it to show that the lane is "active" but not "valid."

@accauble
accauble force-pushed the users/accauble/rj-scalar-routed-access-mask branch from 77235c6 to bc742b0 Compare November 5, 2026 14:04
@accauble
accauble marked this pull request as ready for review November 5, 2026 14:06
@accauble
accauble requested review from a team and atgutier as code owners November 5, 2026 14:06

@kuhar kuhar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@accauble
accauble force-pushed the users/accauble/rj-s-buffer-atomic branch from 4039d70 to 8994908 Compare November 5, 2026 17:07
Base automatically changed from users/accauble/rj-s-buffer-atomic to develop November 5, 2026 18:07
@therock-pr-bot

therock-pr-bot Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

* `report_routed_access` in `ComputeUnitCore` reported valid and
  requested lane masks as "1" even when the whole operation was
  masked. This updates it to show that the lane is "active" but
  not "valid."
@therock-pr-bot

therock-pr-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@accauble
accauble force-pushed the users/accauble/rj-scalar-routed-access-mask branch from bc742b0 to 46fe27f Compare November 5, 2026 18:44
@accauble
accauble merged commit eeb5a57 into develop Nov 6, 2026
68 checks passed
@accauble
accauble deleted the users/accauble/rj-scalar-routed-access-mask branch November 6, 2026 14:07
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

rocjitsu post-commit fuzz passed

The 32-worker multiplexer campaigns for commit eeb5a576604a completed without recording a crash or hang.

  • ASan+UBSan (6-minute): 529,423 input executions (1,503.69 inputs/s)
  • TSan (6-minute): 514,840 input executions (1,474.51 inputs/s)

View the workflow run.

@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants