Repository navigation
fix(rocSHMEM): report bandwidth as GiB/s in reports, #AIROCSHMEM-561 - #14975
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the bandwidth-unit labeling and naming updates.
No open issues 🎉
What changed in this PR
Corrects rocSHMEM functional-test bandwidth units to GiB/s, matching the existing division by 2³⁰ without changing calculations or positional log parsing.
Changes:
- Updates the printed bandwidth header and C++ variable name.
- Renames the Python bandwidth column consistently and corrects the peak-bandwidth docstring.
| File | Description |
|---|---|
projects/rocshmem/tests/functional_tests/tester.cpp |
Labels bandwidth as GiB/s and renames the corresponding variable. |
projects/rocshmem/scripts/functional_tests/perf_compare.py |
Uses bandwidth_gibs throughout parsing and analysis; updates the unit documentation. |
Review effort: Balanced
Resource usage report (4gfx1201) |
Resource usage report (8gfx942) |
Resource usage report (4gfx1201) |
Resource usage report (8gfx942) |
abouteiller
approved these changes
Nov 5, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The functional test computes bandwidth as
bytes / time_s / pow(2, 30)dividing by 2^30, but labels and reports it asGB/s. That value is GiB/s, not GB/s.tester.cpp: relabel the printed headerGB/s->GiB/sand rename the variable. The computation is unchanged; only the unit label now matches what is actually reported.perf_compare.py: rename the matching DataFrame column and fix the docstring. The parser reads fixed columns by position, so this is an internal-consistency rename with no behavioral change.Issue Tracking
JIRA ID: AIROCSHMEM-561