Skip to content

docs(hipfile) removed the fio rocm fork from the fio build instructions - #14915

Merged
spolifroni-amd merged 1 commit into
developfrom
users/spolifroni-amd/hipfile/removed-rocm-fork-from-fio-instructiions
Nov 3, 2026
Merged

spolifroni-amd merged 1 commit into
developfrom
users/spolifroni-amd/hipfile/removed-rocm-fork-from-fio-instructiions

Conversation

@spolifroni-amd

Copy link
Copy Markdown
Contributor

Updated instructions for building fio with libhipfile engine.

JIRA ID : AIROCDOC-4501, AIROCDOC-4534

Updated instructions for building fio with libhipfile engine.
@spolifroni-amd spolifroni-amd added documentation Improvements or additions to documentation project: hipfile labels Nov 3, 2026
@spolifroni-amd
spolifroni-amd requested review from a team as code owners November 3, 2026 15:07
@therock-pr-bot

therock-pr-bot Bot commented Nov 3, 2026

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@peymanr

peymanr commented Nov 3, 2026

Copy link
Copy Markdown

PR Pundit review

(Testing PR Pundit Code Review agent. Not all comments may be relevant. This is a one-time automated pass: please address what is useful, no need to request a re-review. Please reply to each point, whether it applies or not: we harvest these replies, and both kinds are enormously helpful for tuning the agent. Reach out to @peymanr for suggestions.)

# Finding Where
1 🟠 fio configure aborts with feature_not_found libhipfile for non-/opt/rocm installs: this PR switched to upstream fio without ROCM_PATH guidance projects/hipfile/docs/how-to/use-with-fio.rst:17

1. 🟠 Should fix: fio configure aborts with feature_not_found libhipfile for non-/opt/rocm installs: this PR switched to upstream fio without ROCM_PATH guidance

projects/hipfile/docs/how-to/use-with-fio.rst:17

Upstream fio's --enable-libhipfile probe uses ROCM_PATH=${ROCM_PATH:-/opt/rocm} for -I, -L and -rpath. A hipFile/ROCm installed under another prefix, such as an extracted TheRock nightly tarball or a custom CMAKE_INSTALL_PREFIX, makes configure stop with feature_not_found libhipfile. Consider adding a note such as ROCM_PATH=/path/to/rocm ../configure --enable-libhipfile. Removing the old 'doesn't need to be installed system-wide' sentence was correct for upstream fio.

Who is affected: Users who install hipFile/ROCm outside /opt/rocm (nightly tarballs, custom prefixes) and follow the fio build steps verbatim.

Checked against the code by an independent pass.

Shared from a pilot of PR Pundit, an agentic code reviewer that builds and tests the change and reads the project's past reviews. Reviewed at a4a1c1ab; findings checked and posted by @peymanr; points already raised on this PR are left out.

@spolifroni-amd
spolifroni-amd merged commit 2cca84e into develop Nov 3, 2026
34 of 39 checks passed
@spolifroni-amd
spolifroni-amd deleted the users/spolifroni-amd/hipfile/removed-rocm-fork-from-fio-instructiions branch November 3, 2026 17:46
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation organization: ROCm project: hipfile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants