Repository navigation
[rocjitsu] Consolidate arithmetic Debug checks into corpus CI - #14803
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
177ddd7 to
d8f1112
Compare
|
Addressed: the Debug checks now run as steps in the existing Release (Clang) and GCC UBSan jobs. Each uses a separate unsanitized Debug build directory, builds only |
d8f1112 to
7baa08b
Compare
7baa08b to
8d94ee8
Compare
kuhar
left a comment
There was a problem hiding this comment.
Can we move these new steps and constants to happen after the main build steps? I'd like to have it configured so that we go in the order of importance and allow it to fail fast: first regular build, then debug build, then run corpus tests.
8d94ee8 to
dc8ac75
Compare
|
Moved the Debug arithmetic check immediately after the regular build step (which includes its CTest run), before the subsequent integration/corpus checks. Its compiler selections are now local to that Debug step rather than extra matrix fields. YAML and shell syntax checks pass. |
dc8ac75 to
c22d443
Compare
rocjitsu post-commit fuzz passedThe 32-worker multiplexer campaigns for commit
|
TheRock Submodule Bump ActivityNewest first
|
Move Debug arithmetic symbol checks into the existing
rocjitsu-test-corpusjobs and delete the standalone
rocjitsu-arith-debugworkflow.The Release job runs the check with Clang; the GCC UBSan job runs it with GCC.
Each configures a separate, unsanitized Debug build, builds only
rj_arith, andruns
rj_arith.baseline_linkage. No new jobs or simulator builds are added.rj-arith compiles scalar and SIMD backends in separate translation units with
different CPU feature levels. Externally linkable inline helpers, including
standard-library template instantiations, must not share symbols across these
backends: the linker could retain a definition using unsupported instructions
and bypass CPU dispatch. Backend-local callable symbols need ISA identities.
Debug builds expose out-of-line definitions that optimization can hide; the
archive check verifies symbol isolation with both GCC and Clang.
Validation: GCC and Clang Debug library builds and symbol checks pass locally;
YAML and shell syntax checks pass. Existing corpus steps and matrix are unchanged.
Progress towards #13670.