Skip to content

[rocjitsu] Consolidate arithmetic Debug checks into corpus CI - #14803

Merged
kuhar merged 1 commit into
developfrom
users/bjacob/rocjitsu-unify-ci
Nov 4, 2026
Merged

kuhar merged 1 commit into
developfrom
users/bjacob/rocjitsu-unify-ci

Conversation

@bjacob

@bjacob bjacob commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Move Debug arithmetic symbol checks into the existing rocjitsu-test-corpus
jobs and delete the standalone rocjitsu-arith-debug workflow.

The Release job runs the check with Clang; the GCC UBSan job runs it with GCC.
Each configures a separate, unsanitized Debug build, builds only rj_arith, and
runs rj_arith.baseline_linkage. No new jobs or simulator builds are added.

rj-arith compiles scalar and SIMD backends in separate translation units with
different CPU feature levels. Externally linkable inline helpers, including
standard-library template instantiations, must not share symbols across these
backends: the linker could retain a definition using unsupported instructions
and bypass CPU dispatch. Backend-local callable symbols need ISA identities.
Debug builds expose out-of-line definitions that optimization can hide; the
archive check verifies symbol isolation with both GCC and Clang.

Validation: GCC and Clang Debug library builds and symbol checks pass locally;
YAML and shell syntax checks pass. Existing corpus steps and matrix are unchanged.

Progress towards #13670.

@bjacob
bjacob requested review from kuhar, lialan and yashjha123 November 2, 2026 14:57
@bjacob
bjacob requested a review from a team as a code owner November 2, 2026 14:57
@therock-pr-bot

therock-pr-bot Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@github-actions github-actions Bot added the github actions Pull requests that update GitHub Actions code label Nov 2, 2026
@bjacob
bjacob added this pull request to stack #14804 November 2, 2026 14:58
@therock-pr-bot

therock-pr-bot Bot commented Nov 2, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@kuhar kuhar left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this to be consolidated with existing job(s), not just the workflow. We shouldn't grow the number of jobs unless we have a very strong reason.

@bjacob
bjacob force-pushed the users/bjacob/rocjitsu-unify-ci branch from 177ddd7 to d8f1112 Compare November 2, 2026 18:14
@bjacob

bjacob commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Addressed: the Debug checks now run as steps in the existing Release (Clang) and GCC UBSan jobs. Each uses a separate unsanitized Debug build directory, builds only rj_arith, and runs the symbol-isolation check. Removed the separate job matrix and workflow. Both compiler builds and symbol checks pass locally.

@bjacob
bjacob requested a review from kuhar November 2, 2026 18:14
@bjacob
bjacob force-pushed the users/bjacob/rocjitsu-unify-ci branch from d8f1112 to 7baa08b Compare November 3, 2026 14:46
@bjacob
bjacob requested a review from atgutier as a code owner November 3, 2026 14:46
@bjacob
bjacob force-pushed the users/bjacob/rocjitsu-unify-ci branch from 7baa08b to 8d94ee8 Compare November 3, 2026 14:59

@kuhar kuhar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move these new steps and constants to happen after the main build steps? I'd like to have it configured so that we go in the order of importance and allow it to fail fast: first regular build, then debug build, then run corpus tests.

@bjacob
bjacob force-pushed the users/bjacob/rocjitsu-unify-ci branch from 8d94ee8 to dc8ac75 Compare November 3, 2026 16:32
@bjacob

bjacob commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Moved the Debug arithmetic check immediately after the regular build step (which includes its CTest run), before the subsequent integration/corpus checks. Its compiler selections are now local to that Debug step rather than extra matrix fields. YAML and shell syntax checks pass.

@bjacob
bjacob removed this pull request from stack #14804 November 3, 2026 16:43
@bjacob
bjacob force-pushed the users/bjacob/rocjitsu-unify-ci branch from dc8ac75 to c22d443 Compare November 3, 2026 16:43

@kuhar kuhar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuhar
kuhar merged commit 43c2680 into develop Nov 4, 2026
250 of 256 checks passed
@kuhar
kuhar deleted the users/bjacob/rocjitsu-unify-ci branch November 4, 2026 15:30
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

rocjitsu post-commit fuzz passed

The 32-worker multiplexer campaigns for commit 43c2680dba4d completed without recording a crash or hang.

  • ASan+UBSan (6-minute): 612,371 input executions (1,738.28 inputs/s)
  • TSan (6-minute): 515,626 input executions (1,474.87 inputs/s)

View the workflow run.

@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github actions Pull requests that update GitHub Actions code organization: ROCm project: rocjitsu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants