Repository navigation
ci(hipfile): Pass the compat mode variables to the aiscp CI tests - #14740
Merged
Merged
Conversation
github-actions
Bot
added
github actions
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues with the aiscp CI compatibility-mode changes.
No open issues 🎉
What changed in this PR
Fixes hipFile’s aiscp CI steps so the fallback and fastpath tests receive their intended compatibility-mode settings instead of both testing the default I/O path.
Changes:
- Adds shell line continuations to pass each compatibility-mode variable to
ci-aiscp-test.sh. - Makes the fastpath test disallow compatibility fallback, causing it to fail when fastpath is unavailable.
| File | Description |
|---|---|
.github/workflows/hipfile-ci-system.yml |
Passes the intended compatibility-mode settings to both aiscp test commands. |
Review effort: Balanced
Each aiscp step set HIPFILE_FORCE_COMPAT_MODE or HIPFILE_ALLOW_COMPAT_MODE on its own line without a trailing backslash, so the variable never reached ci-aiscp-test.sh and both steps used hipFile's default I/O path. Add the backslash so each step tests the path it names.
kurtmcmillan
force-pushed
the
users/kumcmill/fix-hipfile-ci-aiscp-compat-env
branch
from
November 2, 2026 21:27
941236d to
7a7bdc6
Compare
riley-dixon
approved these changes
Nov 2, 2026
john00003
approved these changes
Nov 2, 2026
derobins
approved these changes
Nov 2, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The aiscp fallback and fastpath steps in
hipfile-ci-system.ymldon't pass their compat mode variable toci-aiscp-test.sh, so both test hipFile's default I/O path.Technical Details
Each step set
HIPFILE_FORCE_COMPAT_MODE=trueorHIPFILE_ALLOW_COMPAT_MODE=falseon its own line without a trailing backslash, which makes it an unexported shell variable. Adding the backslash applies it to theci-aiscp-test.shcommand. The fastpath step now fails if fastpath is unavailable.Issue Tracking
JIRA ID: AIHIPFILE-318
Test Plan
bash -cscript, fromdevelopand from this change, against a stubci-aiscp-test.shthat prints both variables.hipfile-ci-system.yml.Test Result
develop: neither variable reaches the script. This change: each step's variable does.Submission Checklist