Skip to content

ci(rccl): track torch 2.16's renamed pg_timeout test and drop two fixed known failures #14675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prasanna-amd merged 2 commits into from
Nov 2, 2026
Merged

ci(rccl): track torch 2.16's renamed pg_timeout test and drop two fixed known failures #14675

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dbe63c
ci(rccl): track torch 2.16's renamed pg_timeout test and drop the fix…
prasanna-amd Oct 30, 2026
bd48d35
ci(rccl): drop test_comm_recursive_split_group from known failures
prasanna-amd Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions projects/rccl/ci/scripts/known_failures.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"_comment": "Known PyTorch c10d NCCL test failures in this ROCm/RCCL CI suite. Tests listed here are excluded from the pass/fail verdict so that a new failure is visible against them. Most entries are not regressions — some are ROCm runtime behaviour, some are test assumptions that do not hold on ROCm. A minority are active defects with an open ticket, suppressed only to keep the suite's signal readable; those say so explicitly in their category description. Exclusion from the verdict is never a statement that a test is expected to fail forever. Remove each entry once its underlying cause is resolved.",
"tests": {
"test_extend_nccl_pg_timeout_backend0": "pg_timeout_semantics",
"test_extend_nccl_pg_timeout_backend_nccl": "pg_timeout_semantics",
"test_extend_nccl_pg_timeout_backend_nccl-legacy": "pg_timeout_semantics",
"test_on_completion_hook_broadcast": "missing_optype_broadcast",
"test_on_completion_hook_seq": "missing_optype_broadcast",
"test_on_completion_hook_mixed_ops": "missing_optype_broadcast",
Expand Down Expand Up @@ -31,9 +31,7 @@
"test_coalescing_manager_collective_timing_enabled_True": "missing_duration_ms",
"test_individual_send_recv_op_sizes0_timing_enabled_True": "missing_duration_ms",
"test_individual_send_recv_op_sizes1_timing_enabled_True": "missing_duration_ms",
"test_extra_cuda_context": "extra_context_heuristic",
"test_comm_recursive_split_group": "split_group_parent_guard",
"test_nccl_backend_4gpu_module": "nccl_backend_4gpu_hang"
"test_extra_cuda_context": "extra_context_heuristic"
},
"categories": {
"missing_duration_ms": "RCCL flight recorder trace omits duration_ms field",
Expand All @@ -43,8 +41,6 @@
"trace_entry_mismatch": "Trace entry structure differs from upstream NCCL",
"missing_dump_pipe": "RCCL does not create flight recorder dump pipe",
"pg_timeout_semantics": "extend_pg_timeout adds to existing vs sets absolute value",
"extra_context_heuristic": "Test infers an extra HIP context from >70% device memory growth across a collective; on ROCm the growth is a ROCr runtime allocation, not a second context and not RCCL memory. Magnitude is build- and arch-dependent, and the ratio also varies with node co-tenancy (AICOMRCCL-2469)",
"split_group_parent_guard": "Upstream PyTorch #195758 (e8430bed0, 2026-09-03) made split_group reject a parent process group that was bound to a device_id but has not yet run a collective. The test splits recursively without issuing one. Surfaced when this suite moved off a frozen wheel onto the current ROCm nightly; the guard's sibling split_group tests pass on ROCm, so the guard itself is satisfiable here and this is not simply an unsupported upstream API. Which ROCm-side condition leaves the parent group unprimed in this test specifically is not yet identified (AICOMRCCL-3107)",
"nccl_backend_4gpu_hang": "ACTIVE DEFECT, not a feature gap: the 4-GPU DDP module test hangs with both ranks unresponsive and is killed at the 300s timeout. Suppressed only to keep the suite's signal readable while the hang is investigated — remove this entry as soon as AICOMRCCL-2468 is fixed"
"extra_context_heuristic": "Test infers an extra HIP context from >70% device memory growth across a collective; on ROCm the growth is a ROCr runtime allocation, not a second context and not RCCL memory. Magnitude is build- and arch-dependent, and the ratio also varies with node co-tenancy (AICOMRCCL-2469)"
}
}
Loading