Skip to content

fix(rccl): drop duplicate CE AllReduce fakes in rccl_wrap_fakes.cc - #14625

Closed
dlamd1dai wants to merge 1 commit into
developfrom
users/dondai/rccl-wrap-fakes-dup-ce
Closed

dlamd1dai wants to merge 1 commit into
developfrom
users/dondai/rccl-wrap-fakes-dup-ce

Conversation

@dlamd1dai

Copy link
Copy Markdown
Contributor

Motivation

develop no longer builds the RCCL host microtests. #14529 and #13098 each added rcclCeAllReduceEnabled and rcclForceCeAllReduceEnabled to test/host/fakes/rccl_wrap_fakes.cc. Both merged on 2026-10-29, so the Host unit tests (CPU-only) job now fails for every RCCL PR built against develop:

rccl_wrap_fakes.cc:438:6: error: redefinition of 'rcclCeAllReduceEnabled'
rccl_wrap_fakes.cc:441:6: error: redefinition of 'rcclForceCeAllReduceEnabled'

Technical Details

Keep the #13098 definitions. Its rcclCeAllReduceEnabled honors g_rcclParamCeAllReduce, which ce-coll-test.cc sets. Remove the fail-loud copies from #14529. rcclForceCeScratchEnabled, which #14529 added next to them, is unchanged.

Issue Tracking

N/A (develop build break)

Test Plan

In the CI image (rocm/dev-ubuntu-22.04:7.2), run run_host_tests.sh phases deps, rccl-configure, hipify and configure. Then build rccl-UnitTestsMicroCollectives (the target that failed in CI), rccl-UnitTestsMicroCe and rccl-UnitTestsMicro, and run the first two.

Test Result

build                           OK
rccl-UnitTestsMicroCe           [  PASSED  ] 70 tests
rccl-UnitTestsMicroCollectives  [  PASSED  ] 103 tests

Submission Checklist

#14529 and #13098 each defined rcclCeAllReduceEnabled and
rcclForceCeAllReduceEnabled in test/host/fakes/rccl_wrap_fakes.cc, so
develop no longer compiles the host microtests (redefinition errors in
rccl-UnitTestsMicroCollectives and every other target that links the file).

Keep the #13098 definitions: rcclCeAllReduceEnabled honors
g_rcclParamCeAllReduce, which ce-coll-test.cc sets. Remove the
fail-loud copies from #14529.

Co-authored-by: Cursor <cursoragent@cursor.com>
@dlamd1dai
dlamd1dai requested review from a team October 29, 2026 22:55
@therock-pr-bot

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rccl/test/host/fakes/rccl_wrap_fakes.cc; no test file found
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@amd-argus amd-argus Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARGUS

Findings

1 more finding(s), not posted inline
  • projects/rccl/test/host/fakes/rccl_wrap_fakes.cc:418 (Low) The kept rcclCeAllReduceEnabled fake falls back to true, but production falls back to false on every arch except gfx1250 (rccl_wrap.cc:1073). A follow-up could make the fake default to false. As a follow-up, could the kept rcclCeAllReduceEnabled fake fall back to false at line 418? That would match rcclCeCollArchDefault in rccl_wrap.cc:1073-1076, which enables CE AllReduce only on gfx1250. ce-coll-test.cc sets g_rcclParamCeAllReduce, but that value is read through rcclParamCeAllReduce() (ce_coll.cc:3261) and not through this fake, so no current test depends on its default.

Bottom line: LGTM.

Comment @argus review to re-run, or @argus re-review after pushing.

@dlamd1dai

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate: #14633 removed the same duplicate CE AllReduce fakes from rccl_wrap_fakes.cc and has merged to develop.

@dlamd1dai dlamd1dai closed this Oct 31, 2026
@dlamd1dai dlamd1dai self-assigned this Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant