Skip to content

tests(rocprofiler-sdk): Fix Nightly Test Failures - #14503

Merged
itrowbri merged 1 commit into
developfrom
users/itrowbri/strix-halo-test-fix
Nov 4, 2026
Merged

itrowbri merged 1 commit into
developfrom
users/itrowbri/strix-halo-test-fix

Conversation

@itrowbri

@itrowbri itrowbri commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Github Issue was raised where some tests were failing for gfx1151. This PR is specifically addressing the anytime test failures and the hsa-multiqueue test failures.

Technical Details

Changed the anytime tests to measure total memory copied rather than individual memory operations. clr apparently added an optimization where individual memory copy requests can be broken up into several different 1 MiB transfers if the memory copy operation is >1 MiB specifically for the gfx1151 architecture. The anytime initialization tests that used mem-copies therefore have been modified to track the total memory copied rather than the number of memory copy operations performed.

Slightly weakened the hsa-queue-dependency test. I couldn't recreate the issue on the gfx1151 machine nor could I figure out why it might occur. I'm assuming some other environment variable is set resulting in an interaction with rocr-runtime. I modified the test so that the assertion hsa_signal_create == hsa_signal_destroy is tested rather than asserting exactly four hsa_signal_create and hsa_signal_destroy since seven signal create and destroy signals are being found in the gfx1151 nightly test.

Issue Tracking

GitHub issue: #14454

Test Plan

Modified tests to fix gfx1151 nightly failures.

Test Result

The new tests should pass on gfx1151 and fix the nightly failures.

Submission Checklist

Copilot AI balanced review requested due to automatic review settings October 28, 2026 20:22
@itrowbri
itrowbri requested review from a team as code owners October 28, 2026 20:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@therock-pr-bot

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocprofiler-sdk/tests/anytime-tool-config/early-hip-late-memcpy/conftest.py, projects/rocprofiler-sdk/tests/anytime-tool-config/early-hip-late-memcpy/validate.py, projects/rocprofiler-sdk/tests/anytime-tool-config/early-hip-two-late-distinct/conftest.py, projects/rocprofiler-sdk/tests/anytime-tool-config/early-hip-two-late-distinct/validate.py, projects/rocprofiler-sdk/tests/anytime-tool-config/early-hiprccl-late-hipmemcpy/conftest.py (+7 more); no test file found
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

…rix Halo tests. Weakened HSA multiqueue test due to nightly failures as well
@itrowbri
itrowbri force-pushed the users/itrowbri/strix-halo-test-fix branch from 751ee4e to 97a9fb5 Compare October 29, 2026 14:00
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage Report

Code Coverage Report

Tests Only

code coverage tests.png

Samples Only

code coverage samples.png

Tests + Samples

code coverage all.png

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the gfx1151 integration-test updates.

No open issues 🎉

Review effort: Balanced

@itrowbri
itrowbri merged commit 557aa5a into develop Nov 4, 2026
125 of 131 checks passed
@itrowbri
itrowbri deleted the users/itrowbri/strix-halo-test-fix branch November 4, 2026 15:29
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants