Repository navigation
tests(rocprofiler-sdk): Fix Nightly Test Failures - #14503
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
…rix Halo tests. Weakened HSA multiqueue test due to nightly failures as well
itrowbri
force-pushed
the
users/itrowbri/strix-halo-test-fix
branch
from
October 29, 2026 14:00
751ee4e to
97a9fb5
Compare
Contributor
mcao59
approved these changes
Nov 3, 2026
ApoKalipse-V
approved these changes
Nov 4, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
Github Issue was raised where some tests were failing for gfx1151. This PR is specifically addressing the anytime test failures and the hsa-multiqueue test failures.
Technical Details
Changed the anytime tests to measure total memory copied rather than individual memory operations.
clrapparently added an optimization where individual memory copy requests can be broken up into several different 1 MiB transfers if the memory copy operation is >1 MiB specifically for the gfx1151 architecture. The anytime initialization tests that used mem-copies therefore have been modified to track the total memory copied rather than the number of memory copy operations performed.Slightly weakened the
hsa-queue-dependencytest. I couldn't recreate the issue on the gfx1151 machine nor could I figure out why it might occur. I'm assuming some other environment variable is set resulting in an interaction with rocr-runtime. I modified the test so that the assertionhsa_signal_create == hsa_signal_destroyis tested rather than asserting exactly fourhsa_signal_createandhsa_signal_destroysince seven signal create and destroy signals are being found in the gfx1151 nightly test.Issue Tracking
GitHub issue: #14454
Test Plan
Modified tests to fix gfx1151 nightly failures.
Test Result
The new tests should pass on gfx1151 and fix the nightly failures.
Submission Checklist