Repository navigation
[rocjitsu] Bound corpus pytest dependencies - #14456
Merged
kuhar merged 1 commit intoOct 28, 2026
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
github-actions
Bot
added
the
github actions
accauble
approved these changes
Oct 28, 2026
kuhar
approved these changes
Oct 28, 2026
ywang103-amd
pushed a commit
that referenced
this pull request
Oct 28, 2026
Apply compatibility ceilings to the normal corpus and separate DBT Python environments: ```text pytest>=5.4.1,<9.2 pytest-xdist>=1.32.0,<3.9 ``` Pytest 9.2 changed node-ID storage to `_id`, while xdist 3.8 still writes group suffixes to `_nodeid`. Grouping silently stops working, allowing workers to race over shared build/cache directories. The pinned corpus commits lack these ceilings. Apply them during installation rather than bumping corpus SHAs, so the dependency fix does not also change the fixed corpus content or translation baselines. Issue ID: #14457
Contributor
TheRock Submodule Bump ActivityNewest first
|
newling
added a commit
that referenced
this pull request
Nov 4, 2026
#14456 added the pytest/xdist ceilings at install time because the pinned corpus lacked them. The corpus requirements.txt at 8618174 declares the same bounds, so install it alone and keep the dependency policy in one place. The separate DBT venv does not install the corpus requirements and keeps its own bounds. Signed-off-by: James Newling <james.newling@gmail.com>
newling
added a commit
that referenced
this pull request
Nov 5, 2026
#14456 added the pytest/xdist ceilings at install time because the pinned corpus lacked them. The corpus requirements.txt at 8618174 declares the same bounds, so install it alone and keep the dependency policy in one place. The separate DBT venv does not install the corpus requirements and keeps its own bounds. Signed-off-by: James Newling <james.newling@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply compatibility ceilings to the normal corpus and separate DBT Python environments:
Pytest 9.2 changed node-ID storage to
_id, while xdist 3.8 still writes group suffixes to_nodeid. Grouping silently stops working, allowing workers to race over shared build/cache directories.The pinned corpus commits lack these ceilings. Apply them during installation rather than bumping corpus SHAs, so the dependency fix does not also change the fixed corpus content or translation baselines.
Issue ID: #14457