Repository navigation
Conversation
DO NOT MERGE. Temporarily repoints every TheRock ref in therock-multi-arch-ci.yml from commit 488e66e7c222 to the branch ROCm/TheRock@users/geomin12/sparse-fix-dvc so CI can validate that the rocSPARSE/hipSPARSE SuiteSparse test matrices are materialized during the math-libs stage. Validates ROCm/TheRock#9537. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Contributor
Author
|
testing complete |
geomin12
added a commit
to ROCm/TheRock
that referenced
this pull request
Oct 28, 2026
…#9544) --dvc-projects replaces fetch_sources.py's default project list rather than extending it, so the rocm-systems entry listing only "external-rocm-systems" dropped rocm-libraries entirely. pull_large_files() never visited <therock-root>/rocm-libraries, leaving the 24 DVC-tracked rocSPARSE SuiteSparse test matrices unmaterialized and failing the math-libs stage at ClientMatrices.cmake with a configure FATAL_ERROR. hipSPARSE breaks via the same path and is covered by the same fix. This mirrors the bug #8204 fixed in the other direction, so the comment explaining the replace-not-extend semantics is repeated here. Running a test here: ROCm/rocm-systems#14418, rocsparse passed! Fixes #9537 After this lands, I'll bump hashes for rocm-libraries + rocm-systems Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
External
rocm-systemsbuilds droprocm-librariesDVC data, which breaks therocSPARSE configure step in the Windows multi-arch CI math-libs stage:
Root cause and fix live in TheRock: ROCm/TheRock#9537.
--dvc-projectsreplacesfetch_sources.py's default project list rather thanextending it, so
detect_external_repo_config.py'srocm-systemsentry listingonly
external-rocm-systemsdroppedrocm-librariesentirely.pull_large_files()never visited
<therock-root>/rocm-libraries, leaving the 24 DVC-trackedSuiteSparse test matrices unmaterialized. hipSPARSE breaks via the same path.
This is the mirror of the bug ROCm/TheRock#8204 fixed in the other direction.
Technical Details
Repoints all 8 TheRock refs in
.github/workflows/therock-multi-arch-ci.yml(3
uses:+ 5ref:) from the pinned commit488e66e7c222to the branchROCm/TheRock@users/geomin12/sparse-fix-dvc.Only
therock-multi-arch-ci.ymlis modified. No other workflow is touched.Drift check:
488e66e7c222is an ancestor of that branch (42 commits behind).The three reusable workflows changed by
+62/-1in that span, all additive withdefaults (
build_native_windows,rocm_msi_package_version) — no new requiredinputs, so this caller stays compatible.
Issue Tracking
ROCm/TheRock#9537
Test Plan
.github/workflows/therock*is inFULL_TEST_TRIGGER_PATTERNSin.github/scripts/get_changed_projects.py, so this change triggers a fulltest run rather than a skip — confirmed locally via
matches_paths().The math-libs stage is the signal: it is where rocSPARSE/hipSPARSE configure and
where the failure reproduces today.
Test Result
Pending this run. Expected: math-libs configures past
ClientMatrices.cmakewith the matrices materialized by
fetch_sources.py.Submission Checklist