Skip to content

[DO NOT MERGE] test: validate TheRock rocSPARSE/hipSPARSE DVC fix - #14418

Closed
geomin12 wants to merge 1 commit into
developfrom
users/geomin12/test-dvc-rocm-sys
Closed

geomin12 wants to merge 1 commit into
developfrom
users/geomin12/test-dvc-rocm-sys

Conversation

@geomin12

Copy link
Copy Markdown
Contributor

DO NOT MERGE. CI-validation PR only. It temporarily repoints this repo's
multi-arch CI at an unmerged TheRock branch.

Motivation

External rocm-systems builds drop rocm-libraries DVC data, which breaks the
rocSPARSE configure step in the Windows multi-arch CI math-libs stage:

CMake Error at cmake/ClientMatrices.cmake:114 (message):
  Test matrices not found: amazon0312, Chebyshev4, sme3Dc, webbase-1M, rma10, ...

Root cause and fix live in TheRock: ROCm/TheRock#9537.

--dvc-projects replaces fetch_sources.py's default project list rather than
extending it, so detect_external_repo_config.py's rocm-systems entry listing
only external-rocm-systems dropped rocm-libraries entirely. pull_large_files()
never visited <therock-root>/rocm-libraries, leaving the 24 DVC-tracked
SuiteSparse test matrices unmaterialized. hipSPARSE breaks via the same path.

This is the mirror of the bug ROCm/TheRock#8204 fixed in the other direction.

Technical Details

Repoints all 8 TheRock refs in .github/workflows/therock-multi-arch-ci.yml
(3 uses: + 5 ref:) from the pinned commit 488e66e7c222 to the branch
ROCm/TheRock@users/geomin12/sparse-fix-dvc.

Only therock-multi-arch-ci.yml is modified. No other workflow is touched.

Drift check: 488e66e7c222 is an ancestor of that branch (42 commits behind).
The three reusable workflows changed by +62/-1 in that span, all additive with
defaults (build_native_windows, rocm_msi_package_version) — no new required
inputs, so this caller stays compatible.

Issue Tracking

ROCm/TheRock#9537

Test Plan

.github/workflows/therock* is in FULL_TEST_TRIGGER_PATTERNS in
.github/scripts/get_changed_projects.py, so this change triggers a full
test run rather than a skip — confirmed locally via matches_paths().

The math-libs stage is the signal: it is where rocSPARSE/hipSPARSE configure and
where the failure reproduces today.

Test Result

Pending this run. Expected: math-libs configures past ClientMatrices.cmake
with the matrices materialized by fetch_sources.py.

Submission Checklist

DO NOT MERGE. Temporarily repoints every TheRock ref in
therock-multi-arch-ci.yml from commit 488e66e7c222 to the branch
ROCm/TheRock@users/geomin12/sparse-fix-dvc so CI can validate that the
rocSPARSE/hipSPARSE SuiteSparse test matrices are materialized during the
math-libs stage.

Validates ROCm/TheRock#9537.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot added the github actions Pull requests that update GitHub Actions code label Oct 27, 2026
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@geomin12

Copy link
Copy Markdown
Contributor Author

testing complete

@geomin12 geomin12 closed this Oct 28, 2026
@geomin12
geomin12 deleted the users/geomin12/test-dvc-rocm-sys branch October 28, 2026 00:33
geomin12 added a commit to ROCm/TheRock that referenced this pull request Oct 28, 2026
…#9544)

--dvc-projects replaces fetch_sources.py's default project list rather
than extending it, so the rocm-systems entry listing only
"external-rocm-systems" dropped rocm-libraries entirely.
pull_large_files() never visited <therock-root>/rocm-libraries, leaving
the 24 DVC-tracked rocSPARSE SuiteSparse test matrices unmaterialized
and failing the math-libs stage at ClientMatrices.cmake with a configure
FATAL_ERROR. hipSPARSE breaks via the same path and is covered by the
same fix.

This mirrors the bug #8204 fixed in the other direction, so the comment
explaining the replace-not-extend semantics is repeated here.

Running a test here: ROCm/rocm-systems#14418,
rocsparse passed!

Fixes #9537

After this lands, I'll bump hashes for rocm-libraries + rocm-systems

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github actions Pull requests that update GitHub Actions code Not ready to Review organization: ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant