Repository navigation
[rocjitsu][DBI] Move patch gate out and make it test-only - #14388
Merged
Merged
Conversation
github-actions
Bot
added
documentation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
kuhar
reviewed
Oct 27, 2026
Contributor
rocjitsu post-commit fuzz passedThe 32-worker multiplexer campaigns for commit
|
ywang103-amd
pushed a commit
that referenced
this pull request
Oct 28, 2026
## Motivation `patch` is a wrapper for `patch_with_debug_summaries`. In PR #13292, it started to become a convenient place to put gates around instrumentation but have tests avoid them, but this was never the intended design. This PR adds a test-only setting for `patch_with_debug_summaries` so that the instrumentation gates can fall in one place and the tests can still by-pass the gates.
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
patchis a wrapper forpatch_with_debug_summaries. In PR #13292, it started to become a convenient place to put gates around instrumentation but have tests avoid them, but this was never the intended design. This PR adds a test-only setting forpatch_with_debug_summariesso that the instrumentation gates can fall in one place and the tests can still by-pass the gates.