Repository navigation
fix(hip): fix the include of other platforms - #14371
Merged
Merged
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The three focused include changes correct header lookup without identified blocking issues; CI results remain pending.
No open issues 🎉
What changed in this PR
This PR fixes NVIDIA header lookup in HIP’s platform wrappers by using angle-bracket includes instead of quoted includes.
Changes:
- Prevents the three wrappers from including themselves through local header lookup.
- Leaves AMD-specific behavior unchanged.
| File | Description |
|---|---|
projects/hip/include/hip/texture_types.h |
Uses angle brackets to locate NVIDIA texture types. |
projects/hip/include/hip/library_types.h |
Uses angle brackets to locate NVIDIA library types. |
projects/hip/include/hip/driver_types.h |
Uses angle brackets to locate NVIDIA driver types. |
Review effort: Balanced
mangupta
approved these changes
Oct 27, 2026
systems-assistant Bot
pushed a commit
to ROCm/hip
that referenced
this pull request
Oct 28, 2026
## Motivation Change the include from quote to angled bracket. ## Technical Details Currently this does not include headers on other platforms. Changing the angled fixes it. ## Issue Tracking No JIRA is raised for this, this got highlighted via an email ## Test Plan existing test should pass. ## Test Result Awaiting CI Results ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. [rocm-systems] ROCm/rocm-systems#14371 (commit 0032e21)
ywang103-amd
pushed a commit
that referenced
this pull request
Oct 28, 2026
## Motivation Change the include from quote to angled bracket. ## Technical Details Currently this does not include headers on other platforms. Changing the angled fixes it. ## Issue Tracking No JIRA is raised for this, this got highlighted via an email ## Test Plan existing test should pass. ## Test Result Awaiting CI Results ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Change the include from quote to angled bracket.
Technical Details
Currently this does not include headers on other platforms. Changing the angled fixes it.
Issue Tracking
No JIRA is raised for this, this got highlighted via an email
Test Plan
existing test should pass.
Test Result
Awaiting CI Results
Submission Checklist