Repository navigation
fix(hrr): regenerate sources for hipKernelSetCacheConfig - #14278
Closed
danielbolsson wants to merge 1 commit into
Closed
danielbolsson wants to merge 1 commit into
danielbolsson wants to merge 1 commit into
Conversation
AIRUNTIME-3083. hipKernelSetCacheConfig was added to HipDispatchTable on develop (AIRUNTIME-2610) without regenerating the HRR sources, so the generated-files and API-matrix staleness tests fail on develop. Regenerated hrr_api_args.h and both dispatch sources with gen_hrr_api_args.py, and the API matrix baseline and expectations with derive_manifest.py --update-baseline and check_matrix.py --emit-cxx. Capture records it through a generated shim; playback is a no-op because its hipKernel_t argument cannot be rebuilt into a live object. The new runtime slot shifts the compiler API IDs up by one, so HRR_VERSION goes from 10 to 11, and the enable-recording skill's __hipRegisterFatBinary table gains the v11 id. The API matrix workload now calls hipKernelSetCacheConfig, so the T4 sweep exercises it instead of reporting an undeclared coverage gap.
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
Author
|
Closing: #14241 already regenerates the same sources for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : AIRUNTIME-3083
Motivation
#12628 (AIRUNTIME-2610) added
hipKernelSetCacheConfigtoHipDispatchTableondevelopwithout regenerating the HRR sources. The checked-in capture and playback dispatch sources,hrr_api_args.hand the API matrix baseline no longer match the HIP headers, so the two tests inprojects/hrr/tools/tests/test_generated_files_current.pyfail ondevelop, and with them theHRR script testscheck on #13256. This PR regenerates them, as #13472 did forhipKernelSetAttributeForDevice.Technical Details
gen_hrr_api_args.py --check-hrr-coverage. Nothing in them is edited by hand.hipKernelSetCacheConfigis the only API that drifted.hipKernel_targument is one of the opaque types playback cannot turn back into a live object (_UNTRANSLATED_PLAYBACK_TYPES), soplayback_defaults_to_noopapplies without listing it anywhere. Its siblinghipKernelSetAttributeis a no-op for the same reason.hipKernelSetAttributeForDevice, the HIP headers declare it, soapi_matrix.yamlneeds no change. The T4 matrix workload now calls it next tohipKernelSetAttribute; without that call the analyzer reports an undeclared coverage gap.derive_manifest.py --update-baseline, thencheck_matrix.py --emit-cxx. The baseline gains one runtime API, one generated capture and one no-op replay. Re-running both steps on this tree is a no-op.HRR_VERSIONgoes from 10 to 11. The new runtime slot takes the first compiler API ID and shifts the compiler IDs up by one, so a v10 reader would decode those events as the wrong API. The version history inDESIGN.mdand the generator's header comment record v11. The enable-recording skill's__hipRegisterFatBinaryid table ininspect_archive.pygains v11 (551), whichtools/tests/test_skill_api_ids.pyrequires.Issue Tracking
AIRUNTIME-3083. Fixes the
HRR script testsfailure on #13256 that comes fromdevelop.Test Plan
pytest projects/hrr/tests/scripts projects/hrr/tools/tests, including the two staleness tests.gfx950,HIP_VISIBLE_DEVICES=4,5): the API matrix roundtrips T0-T5 and the full integration suite.Test Result
pytest projects/hrr/tests/scripts projects/hrr/tools/tests: 181 passed. The two staleness tests failed ondevelopand pass here.hip_capture_generated.cpp), HRR playback, unit and integration tests all build.hrr-unit-tests: 1512 assertions in 81 test cases pass.hrr-handler-tests: 249 assertions in 31 test cases pass.HIP_VISIBLE_DEVICES=4,5, tree iddaea968daf461dc419dfea08dad7db2ec71a7706matched bydrovr-sync: API matrix T0-T4 pass (400 assertions in 5 test cases), T5 passes (14 assertions), andcheck_matrix.py --resultsreportsfail=0in every tier.hipKernelSetCacheConfigis exercised in T4. The full integration run reports 149 passed / 1 failed / 0 skipped.Unit_HRR_SecureExecIgnoresCaptureOutputfails (AIRUNTIME-3074); the analyzer exits 1 on two T5 coverage notes (hipArray3DCreate,hipArrayCreate); the hosthandler-testsreport a 512-byte ASan leak in ROCr (hsaKmtCreateEventCtx).Submission Checklist