Repository navigation
[rocjitsu] Remove throws from vector move builders - #14192
Merged
Merged
Conversation
Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
kuhar
reviewed
Oct 26, 2026
Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
kuhar
reviewed
Oct 27, 2026
Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
kuhar
approved these changes
Oct 27, 2026
kuhar
left a comment
kuhar
left a comment
Member
There was a problem hiding this comment.
Optional: It would help to refresh emulation/rocjitsu/docs/dbi-design.md:197 and the test inventory at :522 to mention FailureOr with optional diagnostics and CDNA5 selector-254 rejection. Both passages still describe only the 32-bit literal case; a short update would let readers find the new error contract and diagnostic coverage without tracing the header and tests.
LGTM
Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
github-actions
Bot
added
the
documentation
Contributor
rocjitsu post-commit fuzz passedThe 32-worker multiplexer campaigns for commit
|
ywang103-amd
pushed a commit
that referenced
this pull request
Oct 28, 2026
## Motivation Remove C++ exceptions from vector move instruction builders. ## Technical Details Return `FailureOr` with optional diagnostics for unsupported architectures and literal sources. Propagate failures through trampoline construction. Update builder, trampoline, and DBI tests for result-based failures, diagnostics, and supported encodings. Cover CDNA5 literal64 rejection with one diagnostic and preserve silent CDNA1 LDS-direct encoding. ## Issue Tracking Part of #10239. --------- Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove C++ exceptions from vector move instruction builders.
Technical Details
Return
FailureOrwith optional diagnostics for unsupported architectures and literal sources. Propagate failures through trampoline construction.Update builder, trampoline, and DBI tests for result-based failures, diagnostics, and supported encodings. Cover CDNA5 literal64 rejection with one diagnostic and preserve silent CDNA1 LDS-direct encoding.
Issue Tracking
Part of #10239.