[Kapil-Shyam-Pawar]

Motivation

rccl-UnitTestsGinRocshmemGdaPlugin fails to build on develop because PR #13406 changed the GIN-GDA QP API without updating this test target

Technical Details

Added the new traffic_class parameter to the rocshmem_gin_create_qps() stub, and local ncclParamGinIbTc() / ncclParamIbTc() stubs returning the default -1.

Issue Tracking

JIRA ID: AICOMRCCL-3173

Test Plan

Build: ./install.sh -l --debug -t --enable-mpi-tests --rocshmem-gin

Run: ./build/debug/test/rccl-UnitTestsGinRocshmemGdaPlugin

Test Result

• Build succeeds
• Tests pass:

[==========] Running 5 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 5 tests from GinRocshmemGdaPluginTest
[ RUN      ] GinRocshmemGdaPluginTest.CreateContext_StripesSignalsAndCountersPerContext
[       OK ] GinRocshmemGdaPluginTest.CreateContext_StripesSignalsAndCountersPerContext (222 ms)
[ RUN      ] GinRocshmemGdaPluginTest.DestroyContext_ReleasesEveryContextAllocation
[       OK ] GinRocshmemGdaPluginTest.DestroyContext_ReleasesEveryContextAllocation (1 ms)
[ RUN      ] GinRocshmemGdaPluginTest.CreateContext_DefaultsToOneContext
[       OK ] GinRocshmemGdaPluginTest.CreateContext_DefaultsToOneContext (0 ms)
[ RUN      ] GinRocshmemGdaPluginTest.CreateContext_CountersOnlyLeavesSignalFieldsNull
[       OK ] GinRocshmemGdaPluginTest.CreateContext_CountersOnlyLeavesSignalFieldsNull (0 ms)
[ RUN      ] GinRocshmemGdaPluginTest.CreateContext_SignalMrFailureReturnsErrorWithoutLeaking
[       OK ] GinRocshmemGdaPluginTest.CreateContext_SignalMrFailureReturnsErrorWithoutLeaking (0 ms)
[----------] 5 tests from GinRocshmemGdaPluginTest (224 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 1 test suite ran. (224 ms total)
[  PASSED  ] 5 tests.
[ TIMING   ] TEST SUITE          : TEST NAME           :       TIME ms (STATUS)
[ TIMING   ] GinRocshmemGdaPluginTest: CreateContext_StripesSignalsAndCountersPerContext:       0.22 sec (PASS)
[ TIMING   ] GinRocshmemGdaPluginTest: DestroyContext_ReleasesEveryContextAllocation:       0.00 sec (PASS)
[ TIMING   ] GinRocshmemGdaPluginTest: CreateContext_DefaultsToOneContext:       0.00 sec (PASS)
[ TIMING   ] GinRocshmemGdaPluginTest: CreateContext_CountersOnlyLeavesSignalFieldsNull:       0.00 sec (PASS)
[ TIMING   ] GinRocshmemGdaPluginTest: CreateContext_SignalMrFailureReturnsErrorWithoutLeaking:       0.00 sec (PASS)
[ TIMING   ] GinRocshmemGdaPluginTest: TOTAL               :       0.22 sec (PASS)
[ TIMING   ] Total time:       0.00 minutes

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

[therock-pr-bot]

✅ All Policy Checks Passed

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	⚠️ Warning	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*). Current: code file(s) changed: projects/rccl/test/gin/gin_rocshmem_gda_plugin_test_stubs.cc; no test file found
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[alex-breslow-amd]

LGTM

[Copilot]

🟢 Approval recommended

The narrowly scoped stubs match the production interfaces, with no unresolved findings and a reported successful build and five passing tests.

No open issues 🎉

What changed in this PR

Restores compatibility of the standalone GIN-GDA plugin unit-test target with the traffic-class API introduced in #13406. Production code is unchanged.

Changes:

• Adds the new traffic_class argument to the rocshmem_gin_create_qps() stub.
• Provides local traffic-class parameter stubs returning the default -1.

File	Description
projects/​rccl/​test/​gin/​gin_rocshmem_gda_plugin_test_stubs.cc	Updates the QP creation signature and supplies parameter definitions needed by the standalone test target.

_{Review effort: Balanced}

[systems-assistant]

TheRock Submodule Bump Activity

Newest first

• 2026-10-26 — Included in TheRock via ROCm/TheRock#9480.