Repository navigation
fix(hrr): Load COMGR before collecting version - #14133
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow change follows the existing COMGR initialization pattern and guards the version query, with no unresolved findings.
No open issues 🎉
What changed in this PR
This PR fixes COMGR version collection in HRR capture metadata by loading COMGR before querying its version.
Changes:
- Uses the existing
amd::Comgrloader and version-query wrapper. - Records an empty
comgr_versionwhen COMGR is unavailable, avoiding a call to an unresolved entry point.
| File | Description |
|---|---|
projects/clr/hipamd/src/hrr/hip_capture_metadata.cpp |
Initializes COMGR once and checks readiness before collecting its version. |
Review effort: Balanced
andraghetti
approved these changes
Oct 23, 2026
andraghetti
left a comment
andraghetti
left a comment
Contributor
There was a problem hiding this comment.
Ran on MI350: no new failures; hrr-generator-rules fails the same way on develop a08bc31.
mangupta
reviewed
Oct 23, 2026
gandryey
approved these changes
Oct 23, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix HRR capture metadata collection to initialize COMGR before querying its version.
Technical Details
collect_comgr_version()now uses the existingamd::Comgrloader path and checks that COMGR is ready before callingamd::Comgr::get_version(). When COMGR cannot be loaded, capture metadata records an emptycomgr_versioninstead of invoking an unresolved COMGR entry point.Issue Tracking
JIRA ID: ROCM-33422
Test Plan
no change on tests
Test Result
pass all hrr basic cases
Submission Checklist