Skip to content

fix(rocr): Report the owning agent in pointer info for imported VMM mappings #13991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
njhill wants to merge 2 commits into
base: develop
Choose a base branch
from
+11 −9
Draft

fix(rocr): Report the owning agent in pointer info for imported VMM mappings #13991

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d436512
fix(rocr): Report the owning agent in pointer info for imported VMM m…
njhill Oct 19, 2026
1b32a32
fix(rocr): Clarify the imported-handle comment in VMemoryPtrInfo
njhill Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions projects/rocr-runtime/runtime/hsa-runtime/core/runtime/runtime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,8 +527,10 @@ hsa_status_t Runtime::FindDriverMemoryHandle(const void* ptr, const Agent* reque
const MappedHandle& mappedHandle = mapped_it->second;
const auto* mapped_base = reinterpret_cast<const uint8_t*>(mapped_it->first);
if (ptr >= mapped_base && ptr < mapped_base + mappedHandle.size) {
// Imported handles have no owning region, so resolve the owner null-safely.
const MemoryRegion* owner_region = mappedHandle.mem_handle->region;
// An imported handle holds no allocation handle of its own, even once its region is
// recovered from the dma-buf: only the per-agent imports below resolve it.
const MemoryRegion* owner_region =
mappedHandle.mem_handle->imported ? nullptr : mappedHandle.mem_handle->region;
const Agent* owner = owner_region ? owner_region->owner() : nullptr;
if (owner != nullptr && owner->driver().kernel_driver_type_ == requesting_driver) {
*base = const_cast<void*>(mapped_it->first);
Expand Down Expand Up @@ -1116,13 +1118,13 @@ hsa_status_t Runtime::VMemoryPtrInfo(const void* ptr, hsa_amd_pointer_info_t* in
info->sizeInBytes = mappedHandleIt->second.size;
info->registered = true;

// Handles imported from another process (dmabuf or fabric) carry no local region: the
// owning agent and the allocation's memory flags belong to the exporter. Report those as
// unset instead of resolving them through MemoryHandle::region, which is NULL here.
const AMD::MemoryRegion* memRegion =
mappedHandleIt->second.mem_handle->imported
? nullptr
: static_cast<const AMD::MemoryRegion*>(mappedHandleIt->second.mem_handle->region);
// A handle imported from another process (dmabuf or fabric) has no region until its
// placement is recovered from the dma-buf. Once it is, the region names the agent whose
// memory backs the import, as for a local handle. A handle the driver cannot describe, or
// whose memory belongs to an agent outside this process, keeps the owner and flags unset.
MemoryHandle* memHandle = mappedHandleIt->second.mem_handle;
EnsureImportInfo(memHandle);
const AMD::MemoryRegion* memRegion = static_cast<const AMD::MemoryRegion*>(memHandle->region);
info->agentOwner = {};
info->global_flags = 0;
info->alloc_flags = 0;
Expand Down
Loading