Repository navigation
chore(clr): rename HIP_FORCE_API_VERSION to HIP_TARGET_API_VERSION - #13849
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
mangupta
left a comment
There was a problem hiding this comment.
🤖 AI-assisted pre-review (for @mangupta)
[SUGGESTION] No CHANGELOG entry for renaming a user-facing public macro
Users set the API-version selection macro to control which hipDeviceProp_t/hipGetDeviceProperties/hipMemAdvise declarations they get. This PR renames it from HIP_FORCE_API_VERSION to HIP_TARGET_API_VERSION, but the changed-file list contains no release note. Users who pin the API version will not find out that they need to change their build flags.
Suggested fix: Add a projects/clr/CHANGELOG.md entry that names the rename, gives the migration step (use -DHIP_TARGET_API_VERSION=), and states whether HIP_FORCE_API_VERSION is still honored as a deprecated alias (see F-1).
LeoZhao-BJ
left a comment
There was a problem hiding this comment.
LGTM, but just one comment on PR description, you can remove your username in test reult to avoid potential info leak.
TheRock Submodule Bump ActivityNewest first
|
Motivation
Use
HIP_TARGET_API_VERSIONto differentiate us between cuda.Technical Details
Rename to target api version
Issue Tracking
JIRA ID : AIRUNTIME-3032
Test Plan
Should replace
HIP_FORCE_API_VERSIONtoHIP_TARGET_API_VERSION.Test Result
Submission Checklist