Skip to content

chore(clr): rename HIP_FORCE_API_VERSION to HIP_TARGET_API_VERSION - #13849

Merged
mikeqinamd merged 1 commit into
developfrom
users/mqin/target-api-level
Oct 26, 2026
Merged

mikeqinamd merged 1 commit into
developfrom
users/mqin/target-api-level

Conversation

@mikeqinamd

@mikeqinamd mikeqinamd commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Use HIP_TARGET_API_VERSION to differentiate us between cuda.

Technical Details

Rename to target api version

Issue Tracking

JIRA ID : AIRUNTIME-3032

Test Plan

Should replace HIP_FORCE_API_VERSION to HIP_TARGET_API_VERSION.

Test Result

-*- mode: ripgrep-search; default-directory: "c:/Users/user/pub/TheRock/" -*-
Ripgrep started at Tue Oct 20 13:45:26

rg  --no-heading --line-number --with-filename --color=always -- "HIP_FORCE_API_VERSION" .

Ripgrep exited abnormally with code 1 at Tue Oct 20 13:45:54, duration 28.3 s

Submission Checklist

@mikeqinamd
mikeqinamd requested review from a team as code owners October 20, 2026 20:00
@mikeqinamd mikeqinamd self-assigned this Oct 20, 2026
@therock-pr-bot

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/hip-tests/catch/unit/device/hipGetDeviceProperties_R0000.cc, projects/hip/include/hip/hip_common.h, projects/hip/include/hip/hip_runtime_api.h, projects/hrr/playback/hip_playback_generated.cpp, projects/hrr/tools/gen_hrr_api_args.py; no test file found
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@mangupta mangupta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI-assisted pre-review (for @mangupta)

[SUGGESTION] No CHANGELOG entry for renaming a user-facing public macro

Users set the API-version selection macro to control which hipDeviceProp_t/hipGetDeviceProperties/hipMemAdvise declarations they get. This PR renames it from HIP_FORCE_API_VERSION to HIP_TARGET_API_VERSION, but the changed-file list contains no release note. Users who pin the API version will not find out that they need to change their build flags.

Suggested fix: Add a projects/clr/CHANGELOG.md entry that names the rename, gives the migration step (use -DHIP_TARGET_API_VERSION=), and states whether HIP_FORCE_API_VERSION is still honored as a deprecated alias (see F-1).

Comment thread projects/hip/include/hip/hip_common.h Resolved

@LeoZhao-BJ LeoZhao-BJ left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but just one comment on PR description, you can remove your username in test reult to avoid potential info leak.

@mikeqinamd
mikeqinamd merged commit 7af0bc5 into develop Oct 26, 2026
2238 of 2299 checks passed
@mikeqinamd
mikeqinamd deleted the users/mqin/target-api-level branch October 26, 2026 15:38
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants