Repository navigation
[rocjitsu] Test RDNA FP16 and BF16 WMMA accumulator handling - #13814
Conversation
kuhar
left a comment
There was a problem hiding this comment.
It would help to make the test descriptions identify the expanded scope and capture architecture:
emulation/rocjitsu/tests/rdna_wmma_float_test.cpp:4: include dense FP16/BF16 packed-half and accumulator regressions in the file summary, which currently mentions FP8/BF8 and mixed formats.emulation/rocjitsu/tests/fixtures/float_dot/rdna_f16_samples.h:11: name the samplekWmmaF16Gfx11High(as withkWmmaIu8Gfx11). FP16 WMMA exists on both targets, so carrying the architecture in the identifier makes the captured result's scope visible at its use site.
1f4371e to
66cd849
Compare
|
Addressed the review, including the expanded file summary and Validation at this commit: all 15 focused matrix C++ tests and all applicable pre-commit hooks pass. The earlier emulation job's reported failures also occur in the base develop job; it stopped with a custom-container error. Fresh CI is running on the updated commit. |
66cd849 to
60643a4
Compare
kuhar
left a comment
There was a problem hiding this comment.
Added 2 comments and an inline reply
60643a4 to
4728d01
Compare
4728d01 to
9a4c5e1
Compare
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Add a few captured regressions for RDNA3 packed destination halves, RDNA4 subnormal accumulators, and BF16 factor encoding. Keep the existing arithmetic models unchanged. Co-authored-by: Benoit Jacob <jacob.benoit.1@gmail.com>
9a4c5e1 to
8602f04
Compare
TheRock Submodule Bump ActivityNewest first
|
Originally by @kuhar, with cleanup by @bjacob .
Add focused decoded WMMA regressions for RDNA3 packed destination halves, RDNA4 subnormal accumulators, and BF16 factor encoding.
Reuse the matrix input generator and runner, with a small sample of original expected outputs.
This commit only adds tests; the arithmetic implementations are unchanged.
Validation: GCC Release build and 22 focused C++ tests pass at the four-commit stack tip; generator-profile tests also pass.
Stacked on #13813.
Progress towards #13670.