Skip to content

[rocjitsu] Test RDNA FP16 and BF16 WMMA accumulator handling - #13814

Merged
bjacob merged 1 commit into
users/bjacob/rocjitsu-rdna4-float-swmmacfrom
users/bjacob/rocjitsu-rdna-wmma-accumulator-tests
Oct 21, 2026
Merged

bjacob merged 1 commit into
users/bjacob/rocjitsu-rdna4-float-swmmacfrom
users/bjacob/rocjitsu-rdna-wmma-accumulator-tests

Conversation

@bjacob

@bjacob bjacob commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Originally by @kuhar, with cleanup by @bjacob .

Add focused decoded WMMA regressions for RDNA3 packed destination halves, RDNA4 subnormal accumulators, and BF16 factor encoding.
Reuse the matrix input generator and runner, with a small sample of original expected outputs.

This commit only adds tests; the arithmetic implementations are unchanged.

Validation: GCC Release build and 22 focused C++ tests pass at the four-commit stack tip; generator-profile tests also pass.

Stacked on #13813.

Progress towards #13670.

@kuhar kuhar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would help to make the test descriptions identify the expanded scope and capture architecture:

  • emulation/rocjitsu/tests/rdna_wmma_float_test.cpp:4: include dense FP16/BF16 packed-half and accumulator regressions in the file summary, which currently mentions FP8/BF8 and mixed formats.
  • emulation/rocjitsu/tests/fixtures/float_dot/rdna_f16_samples.h:11: name the sample kWmmaF16Gfx11High (as with kWmmaIu8Gfx11). FP16 WMMA exists on both targets, so carrying the architecture in the identifier makes the captured result's scope visible at its use site.

@bjacob
bjacob force-pushed the users/bjacob/rocjitsu-rdna-wmma-accumulator-tests branch from 1f4371e to 66cd849 Compare October 20, 2026 17:53
@bjacob

bjacob commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the review, including the expanded file summary and kWmmaF16Gfx11High fixture name. The fixture uses the lightweight sample header and is listed in the fixture index. The extra BF16 architecture-contrast case is only a few lines.

Validation at this commit: all 15 focused matrix C++ tests and all applicable pre-commit hooks pass.

The earlier emulation job's reported failures also occur in the base develop job; it stopped with a custom-container error. Fresh CI is running on the updated commit.

@bjacob
bjacob requested a review from kuhar October 20, 2026 18:00
@bjacob
bjacob force-pushed the users/bjacob/rocjitsu-rdna-wmma-accumulator-tests branch from 66cd849 to 60643a4 Compare October 20, 2026 19:26

@kuhar kuhar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 comments and an inline reply

@bjacob
bjacob force-pushed the users/bjacob/rocjitsu-rdna-wmma-accumulator-tests branch from 60643a4 to 4728d01 Compare October 21, 2026 14:40
@bjacob
bjacob added this pull request to stack #13925 October 21, 2026 16:32
@bjacob
bjacob force-pushed the users/bjacob/rocjitsu-rdna-wmma-accumulator-tests branch from 4728d01 to 9a4c5e1 Compare October 21, 2026 17:38
@therock-pr-bot

therock-pr-bot Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ❌ Fail Error: Check concluded with cancelled.
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ pre-commit

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@bjacob
bjacob removed this pull request from stack #13925 October 21, 2026 17:50
@bjacob
bjacob added this pull request to stack #13932 October 21, 2026 17:52
Add a few captured regressions for RDNA3 packed destination halves, RDNA4 subnormal accumulators, and BF16 factor encoding. Keep the existing arithmetic models unchanged.

Co-authored-by: Benoit Jacob <jacob.benoit.1@gmail.com>
@bjacob
bjacob force-pushed the users/bjacob/rocjitsu-rdna-wmma-accumulator-tests branch from 9a4c5e1 to 8602f04 Compare October 21, 2026 17:53
@bjacob
bjacob merged commit 39fd0ea into develop Oct 21, 2026
77 of 95 checks passed
@bjacob
bjacob deleted the users/bjacob/rocjitsu-rdna-wmma-accumulator-tests branch October 21, 2026 18:37
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants