Skip to content

feat(ci): removing single arch CI files for rocm-systems - #13791

Merged
geomin12 merged 5 commits into
developfrom
users/geomin12/cleanup-single-arch
Oct 26, 2026
Merged

feat(ci): removing single arch CI files for rocm-systems#13791
geomin12 merged 5 commits into
developfrom
users/geomin12/cleanup-single-arch

Conversation

@geomin12

@geomin12 geomin12 commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

removing single arch CI files for rocm-systems

media-libs is being deprecated shortly as it migrates to multi-arch CI, but as of now, it will be kept as it is used.

Progress on ROCm/TheRock#9368

Passing here: https://github.com/ROCm/rocm-systems/actions/runs/39349504951

geomin12 and others added 3 commits October 19, 2026 15:11
@geomin12 @claude
ci: remove unused single-arch TheRock CI workflows
b7ae4f9 
The single-arch TheRock CI was superseded by multi-arch CI in f47ea69
(2026-09-21), which gated therock-ci.yml behind a ci:single-arch label.
No pull request has ever applied that label, so every PR run since then
has been a gate-only no-op with all downstream jobs skipped.

Remove the workflow and everything whose only consumer was it:

  - therock-ci.yml, therock-ci-windows.yml, therock-build-linux.yml
  - therock-test-packages.yml, reachable only through a job that its
    sole remaining caller (media-libs-ci.yml) hard-gated off by passing
    test_runs_on: ""
  - therock_configure_ci.py, therock_matrix.py and their tests

therock-ci-linux.yml stays, since media-libs-ci.yml builds with it, but
drops the now-unreachable test job and the three inputs that only fed it.
therock-test-component.yml also stays, as therock-media-test-packages.yml
still uses it.

The README CI badge and a few stale comments and test fixtures are
repointed at therock-multi-arch-ci.yml. TheRock CI Summary is not a
required status check on develop, so dropping it does not affect merges.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12 @claude
ci: remove Media Libs CI and its reusable workflow chain
2069512 
Deletes media-libs-ci.yml along with the three reusable workflows that
had no other consumer once it was gone:

  - therock-ci-linux.yml          (sole caller: media-libs-ci.yml)
  - therock-media-test-packages.yml (sole caller: media-libs-ci.yml)
  - therock-test-component.yml    (sole caller: therock-media-test-packages.yml)

Note this removes active CI coverage: media-libs-ci.yml was still
building and testing rocDecode and rocJPEG on pushes to develop and on
pull requests touching projects/rocdecode or projects/rocjpeg, most
recently on 2026-10-19. It is not a required status check on develop,
so merges are unaffected, but rocDecode and rocJPEG now have no
replacement pipeline in this repo.

Drops the Media Libs CI badges from the README component table and the
stale CI pointer in projects/rocdecode/CLAUDE.md.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12 @claude
Revert "ci: remove Media Libs CI and its reusable workflow chain"
6b138ab 
This reverts commit 2069512, restoring media-libs-ci.yml and the
three reusable workflows it depends on. That removal would have left
rocDecode and rocJPEG with no build or test coverage, and no replacement
pipeline exists in this repo.

The restore keeps the trimming from b7ae4f9: therock-ci-linux.yml
stays build-only, without the unreachable test job or the three inputs
that only fed it.

Mark the three supporting workflows as deprecated, since they are now
single-purpose leftovers of the removed TheRock single-arch CI rather
than the shared workflows their names suggest:

  - therock-ci-linux.yml
  - therock-media-test-packages.yml
  - therock-test-component.yml

The banners are comments only, so behavior is unchanged. media-libs-ci.yml
is deliberately left unmarked; it remains the supported entry point for
media libs CI.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12
geomin12 requested a review from a team as a code owner October 20, 2026 00:39
@github-actions github-actions Bot added documentation Improvements or additions to documentation github actions Pull requests that update GitHub Actions code labels Oct 20, 2026
@therock-pr-bot

therock-pr-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

dysu-amd
dysu-amd approved these changes Oct 20, 2026
View reviewed changes

@dysu-amd dysu-amd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would like a review from media-libs team as well since it touches their ci

Side note, https://github.com/ROCm/rocm-systems/blob/develop/docs/continuous-integration.md is terribly outdated, still has Azure pipelines docs that I wrote over a year ago 🫤, should probably address that eventually

@dysu-amd
dysu-amd requested a review from kiritigowda October 20, 2026 18:12
@geomin12

geomin12 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

LGTM, would like a review from media-libs team as well since it touches their ci

Side note, https://github.com/ROCm/rocm-systems/blob/develop/docs/continuous-integration.md is terribly outdated, still has Azure pipelines docs that I wrote over a year ago 🫤, should probably address that eventually

oh wow! we can update in a follow-up

@geomin12 @claude
Merge remote-tracking branch 'origin/develop' into users/geomin12/cle…
6fa402c 
…anup-single-arch

Resolved 4 modify/delete conflicts by keeping the deletions from this
branch. develop's only change to these files came from ba2655b
("Update TheRock ref to 488e66e"), a mechanical pin bump, so there was
no logic to preserve:

  .github/workflows/therock-build-linux.yml
  .github/workflows/therock-ci-windows.yml
  .github/workflows/therock-ci.yml
  .github/workflows/therock-test-packages.yml

The 488e66e pin bump still landed in the retained workflows via
auto-merge, and therock-ci-linux.yml continues to route through
therock-test-component.yml, so no callers are left dangling.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12
geomin12 requested a review from a team as a code owner October 26, 2026 14:02
araravik-psd
araravik-psd approved these changes Oct 26, 2026
View reviewed changes

@araravik-psd araravik-psd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a small nit(not blocking).Approved

Comment thread .github/scripts/compute_build_stages.py Outdated
# everything (empty allowlist) to preserve coverage, mirroring the pre-multi-arch
# CI where clr/hip/rocr-runtime, amdsmi, and profiler mapped to
# -DTHEROCK_ENABLE_ALL=ON in .github/scripts/therock_matrix.py.
# -DTHEROCK_ENABLE_ALL=ON.

@araravik-psd araravik-psd Oct 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Nit: Can we add a sentence here showing where the mapping happens from now(as we have removed therock_matrix.py now), just for consistency and ease of tracking

@geomin12 @claude
docs(ci): point FULL_BUILD_PROJECTS comment at the current mapping
3a619a0 
therock_matrix.py is gone, so note that this set is now where the
project -> full-build mapping lives.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12
geomin12 merged commit e5eaa74 into develop Oct 26, 2026
30 of 32 checks passed
@geomin12
geomin12 deleted the users/geomin12/cleanup-single-arch branch October 26, 2026 15:14
@pvallem pvallem mentioned this pull request Oct 26, 2026
Open
1 task done
@systems-assistant

systems-assistant Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

@ScottTodd ScottTodd mentioned this pull request Oct 27, 2026
Merged
1 task done
ScottTodd added a commit that referenced this pull request Oct 28, 2026
@ScottTodd
[bkc] Pin to use release/bkc/therock-10.3-20261027 (#14369)
216280b 
## Motivation

* See ROCm/rockrel#88

## Technical Details

* Note that #13791 narrowly
missed the branch cut, so old workflows are still updated here

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
@amontoison amontoison mentioned this pull request Nov 3, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dysu-amd dysu-amd dysu-amd approved these changes
@jayhawk-commits jayhawk-commits Awaiting requested review from jayhawk-commits
@HereThereBeDragons HereThereBeDragons Awaiting requested review from HereThereBeDragons
@kiritigowda kiritigowda Awaiting requested review from kiritigowda
+1 more reviewer
@araravik-psd araravik-psd araravik-psd approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation github actions Pull requests that update GitHub Actions code organization: ROCm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@geomin12 @araravik-psd @dysu-amd