Skip to content

ci(rocprofiler-sdk): raise code coverage test step timeouts to 45 min - #13760

Merged
lamikr merged 1 commit into
developfrom
users/meserve-amd/codecov-timeout-45
Oct 20, 2026
Merged

lamikr merged 1 commit into
developfrom
users/meserve-amd/codecov-timeout-45

Conversation

@meserve-amd

@meserve-amd meserve-amd commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

The Total and Tests code coverage steps each run nearly the full test suite and have been taking 27-30 minutes, so the Total step now regularly hits its 30 minute timeout. Raise both to 45 minutes.

Technical Details

Will do a follow up to audit what the coverage test is doing and can be reduced. Currently, we have multiple coverage tools running and we need to evaluate what we're actually using.

Issue Tracking

JIRA ID: AIPROFSDK-902

Test Plan

Use this PR's CI run

Test Result

Submission Checklist

…utes

The Total and Tests code coverage steps each run nearly the full test
suite and have been taking 27-30 minutes, so the Total step now regularly
hits its 30 minute timeout. Raise both to 45 minutes.
@meserve-amd
meserve-amd requested a review from a team as a code owner October 19, 2026 17:56
@github-actions github-actions Bot added the github actions Pull requests that update GitHub Actions code label Oct 19, 2026
@therock-pr-bot

therock-pr-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage Report

Code Coverage Report

Tests Only

code coverage tests.png

Samples Only

code coverage samples.png

Tests + Samples

code coverage all.png

@lamikr

lamikr commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

I have some concern that the total runtime of this test setup (around 70 min) is in total too long because quite often I have seen some flaky test failures happening. We can increase this timeout but I think we should also have another PR to split the tests to 2 different CI job:

  1. Total code coverage
  2. Tests code coverage + Samples code coverage

@lamikr

lamikr commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Merging now, based on to discussions, other improvements to reduce the build time of this CI job will be addressed on follow up PRs.

@lamikr
lamikr merged commit fc19ace into develop Oct 20, 2026
199 of 216 checks passed
@lamikr
lamikr deleted the users/meserve-amd/codecov-timeout-45 branch October 20, 2026 19:35
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github actions Pull requests that update GitHub Actions code Not ready to Review organization: ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants