Skip to content

docs(hipfile) adding docs info on p2pdma support on linux kernels - #13756

Merged
akolliasAMD merged 16 commits into
developfrom
users/akolliasamd/p2pdmaupdatev2
Oct 21, 2026
Merged

akolliasAMD merged 16 commits into
developfrom
users/akolliasamd/p2pdmaupdatev2

Conversation

@akolliasAMD

Copy link
Copy Markdown
Contributor

Motivation

The p2pdma requirement for hipfile needs more documentation (copy of 12662 PR for building docs)

Technical Details

N/A

Issue Tracking

JIRA ID : AIHIPFILE-278

Test Plan

Test Result

Submission Checklist

Copilot AI balanced review requested due to automatic review settings October 19, 2026 17:23
@akolliasAMD
akolliasAMD requested review from a team as code owners October 19, 2026 17:23
@github-actions github-actions Bot added documentation Improvements or additions to documentation project: hipfile labels Oct 19, 2026
@therock-pr-bot

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@spolifroni-amd

Copy link
Copy Markdown
Contributor

/docs-preview

@systems-assistant

Copy link
Copy Markdown
Contributor

Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-akolliasamd-p2pdmaupdatev2/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The guidance incorrectly treats a PCIe-specific requirement as universal and guarantees fallback even when it is disabled.

2 open issues
What changed in this PR

This documentation-only PR explains hipFile’s kernel P2PDMA requirements and helps users diagnose unavailable fastpath support.

Changes:

  • Adds kernel checks and Ubuntu HWE installation guidance.
  • Introduces a kernel support matrix with VM test results.
  • Links the guidance throughout installation and troubleshooting documentation.
File Description
projects/​hipfile/​docs/​troubleshooting/​troubleshooting.rst Adds P2PDMA diagnostics.
projects/​hipfile/​docs/​troubleshooting/​limitations.rst Documents kernel requirements.
projects/​hipfile/​docs/​troubleshooting/​known-issues.rst Describes Ubuntu’s default-kernel limitation and workaround.
projects/​hipfile/​docs/​sphinx/​_toc.yml.in Adds matrix navigation.
projects/​hipfile/​docs/​reference/​hipFile-kernel-support-matrix.rst Records tested kernels and VM results.
projects/​hipfile/​docs/​install/​install.rst Adds kernel checks and upgrade instructions.
projects/​hipfile/​docs/​install/​build-from-source.rst Clarifies fastpath prerequisites.
projects/​hipfile/​docs/​how-to/​checking-system-compatibility.rst Explains capability detection and diagnostic results.
projects/​hipfile/​CHANGELOG.md Records the documentation update.

Review effort: Balanced

@spolifroni-amd

Copy link
Copy Markdown
Contributor

/docs-preview

@systems-assistant

Copy link
Copy Markdown
Contributor

Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-akolliasamd-p2pdmaupdatev2/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.)

@spolifroni-amd

Copy link
Copy Markdown
Contributor

/docs-preview

@systems-assistant

Copy link
Copy Markdown
Contributor

Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-akolliasamd-p2pdmaupdatev2/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.)

@spolifroni-amd

Copy link
Copy Markdown
Contributor

/docs-preview

@systems-assistant

Copy link
Copy Markdown
Contributor

Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-akolliasamd-p2pdmaupdatev2/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.)

@spolifroni-amd

Copy link
Copy Markdown
Contributor

/docs-preview

@systems-assistant

Copy link
Copy Markdown
Contributor

Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-akolliasamd-p2pdmaupdatev2/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.)

@spolifroni-amd

Copy link
Copy Markdown
Contributor

The links to readthedocs are apppearing randomly. Here is the link to the latest build:
https://rocm.docs.amd.com/projects/hipFile/en/users-akolliasamd-p2pdmaupdatev2/index.html

@akolliasAMD
akolliasAMD force-pushed the users/akolliasamd/p2pdmaupdatev2 branch from 54280db to ed95093 Compare October 21, 2026 01:39
@spolifroni-amd

Copy link
Copy Markdown
Contributor

/docs-preview

@systems-assistant

Copy link
Copy Markdown
Contributor

Docs preview for hipfile is building on Read the Docs: https://rocm.docs.amd.com/projects/hipFile/en/users-akolliasamd-p2pdmaupdatev2/ (Note: If a pull request includes multiple projects, only the preview for the first project will be built.)

@akolliasAMD akolliasAMD added noCI ci:skip Skip all CI builds/tests for this PR labels Oct 21, 2026
@akolliasAMD
akolliasAMD force-pushed the users/akolliasamd/p2pdmaupdatev2 branch from ed95093 to 6d9319c Compare October 21, 2026 15:40
@akolliasAMD
akolliasAMD merged commit 9f53b64 into develop Oct 21, 2026
72 of 73 checks passed
@akolliasAMD
akolliasAMD deleted the users/akolliasamd/p2pdmaupdatev2 branch October 21, 2026 15:53
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip Skip all CI builds/tests for this PR documentation Improvements or additions to documentation noCI organization: ROCm project: hipfile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants