Repository navigation
test(rocprofiler-sdk): range replay week of 2026-10-19: C3, C4 (stacked) - #13744
Draft
amd-vkale wants to merge 2 commits into
Conversation
Extend tests/range-replay-declines with hipMalloc and hipFree inside a bound range (ALLOCATION_CHANGED_IN_RANGE at close) and an empty range (NO_DISPATCH). The tool takes RR_DECLINE_EXPECT_DISPATCHES per mode so C1/C2 still expect one dispatch while C4 expects zero. Co-authored-by: Vivek Kale <vivek.kale@amd.com>
The declines coverage row and the missing-tests preamble now name the allocation-change and empty-range hardware cases. Co-authored-by: Vivek Kale <vivek.kale@amd.com>
1 task
This was referenced Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Week three of the range replay test roadmap (
source/docs/conceptual/range_replay/range_replay_test_plan.md): C3 and C4. A range whose tracked allocation set changes between the entry snapshot and close must decline withALLOCATION_CHANGED_IN_RANGErather than restore into memory the application has since repurposed; an empty range must close withNO_DISPATCH. Both are bookkeeping-covered in unit tests; this PR drives them on hardware and checks that no pass runs and the application's own result is intact.Stacked on #13272 (week two: C8).
Technical Details
Extends
tests/range-replay-declines/(C1/C2) with three newRR_DECLINE_MODEvalues:hip-malloc(C3). One binding kernel takes the entry snapshot;hipMallocinside the range changes the tracked set; CLOSE reportsALLOCATION_CHANGED_IN_RANGEwith one observed dispatch and zero passes;acc == 1.hip-free(C3). Same shape, buthipFreeof a pre-range allocation after the binding kernel.empty(C4).beginthenendwith no dispatch; CLOSE reportsNO_DISPATCHwith zero dispatches.The tool now takes
RR_DECLINE_EXPECT_DISPATCHESper mode so C1/C2 still expect one dispatch while C4 expects zero. The roadmap coverage row and missing-tests preamble record C3 and C4.Issue Tracking
Related: #10864 (range replay, whose allocation-set check and empty-range CLOSE this exercises).
Test Plan
test-range-replay-decline-hip-malloc,test-range-replay-decline-hip-free,test-range-replay-decline-emptyon the mi325 CI jobs (plus the existing C1/C2 modes still registered from this suite).-fsyntax-onlyagainst HIP headers were not available here (nohip/hip_runtime.h/ nolibstdc++for a CMake compiler test).Test Result
CI for this PR is pending. Nothing could be run on a GPU locally.
Week two (#13272,
5758d889a0): C8 (test-range-replay-concurrent-graph-launch) PASSED on Core rhel-8.8, rhel-9.5, sles-15.6, and on ubuntu-22.04's main suite. Ubuntu Core was red for other tests (not C8); coverage hit limits; Multi-Arch summary failed / cancelled stages.#10864 is unchanged at
0844152fe6; its Core reds remain pre-existing flakes / bot timeouts (rocshmem, samples, therock-pr-bot), not range-replay regressions.Submission Checklist