Repository navigation
fix(rocprofiler-compute): Preserve PC sampling code object identity - #13742
Merged
vedithal-amd merged 2 commits intoOct 19, 2026
Merged
vedithal-amd merged 2 commits into
vedithal-amd merged 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change matches the object-relative decoding contract and includes regression coverage, with no unresolved issues identified.
No open issues 🎉
What changed in this PR
Preserves code object identity during PC sampling decoding, preventing finalization failures when GPU addresses are reused.
Changes:
- Decodes instructions using the code object ID and relative address.
- Adds regression coverage for reused addresses within and beyond the older object’s range.
- Documents the fix in the changelog.
| File | Description |
|---|---|
| projects/rocprofiler-compute/src/lib/pc_sampling_collector/tests/test_code_object_translator.h | Defines the translator test fixture. |
| projects/rocprofiler-compute/src/lib/pc_sampling_collector/tests/test_code_object_translator.cpp | Tests decoding distinct objects sharing a load address. |
| projects/rocprofiler-compute/src/lib/pc_sampling_collector/tests/CMakeLists.txt | Registers the new test files. |
| projects/rocprofiler-compute/src/lib/pc_sampling_collector/code_object_translator.cpp | Uses object-specific instruction lookup. |
| projects/rocprofiler-compute/CHANGELOG.md | Records the JAX and PyTorch sampling fix. |
Review effort: Balanced
feizheng10
reviewed
Oct 19, 2026
feizheng10
left a comment
feizheng10
left a comment
Contributor
There was a problem hiding this comment.
Two non-blocking notes.
feizheng10
approved these changes
Oct 19, 2026
vedithal-amd
approved these changes
Oct 19, 2026
vedithal-amd
left a comment
vedithal-amd
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Decoding by code object id plus offset matches how rocprofv3 decodes samples, and the new test fails without the change: the reused address decodes the old object, and the lookup past the old range throws. Also verified locally on gfx950: cold-cache torch.compile max-autotune runs now write the ISA listing with both stochastic and host_trap.
vedithal-amd
pushed a commit
that referenced
this pull request
Oct 25, 2026
…13742) ## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> Prevent JAX/PyTorch PC sampling finalization failures when GPU addresses are reused. ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> - Decode instructions using the code object ID and relative address. - Add a regression test for reused addresses. ## Issue Tracking <!-- Include a GitHub Issue and/or JIRA ID. Do not post any full JIRA links here. --> <!-- GitHub issue: #1234 --> <!-- JIRA ID: EXAMPLECOMPONENT-1234 --> JIRA ID: ROCM-32558 ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> - Run collector tests. - Validate JAX sampling and PyTorch cold-cache training on MI350X. - Check clean exit, cleanup and ISA output. ## Test Result <!-- Briefly summarize test outcomes. --> - All 68 PC sampling collector tests passed, including the new test for this bug. - JAX and PyTorch validation passed. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
vedithal-amd
pushed a commit
that referenced
this pull request
Oct 26, 2026
…13742) ## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> Prevent JAX/PyTorch PC sampling finalization failures when GPU addresses are reused. ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> - Decode instructions using the code object ID and relative address. - Add a regression test for reused addresses. ## Issue Tracking <!-- Include a GitHub Issue and/or JIRA ID. Do not post any full JIRA links here. --> <!-- GitHub issue: #1234 --> <!-- JIRA ID: EXAMPLECOMPONENT-1234 --> JIRA ID: ROCM-32558 ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> - Run collector tests. - Validate JAX sampling and PyTorch cold-cache training on MI350X. - Check clean exit, cleanup and ISA output. ## Test Result <!-- Briefly summarize test outcomes. --> - All 68 PC sampling collector tests passed, including the new test for this bug. - JAX and PyTorch validation passed. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
lamikr
pushed a commit
that referenced
this pull request
Oct 27, 2026
…13742) ## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> Prevent JAX/PyTorch PC sampling finalization failures when GPU addresses are reused. ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> - Decode instructions using the code object ID and relative address. - Add a regression test for reused addresses. ## Issue Tracking <!-- Include a GitHub Issue and/or JIRA ID. Do not post any full JIRA links here. --> <!-- GitHub issue: #1234 --> <!-- JIRA ID: EXAMPLECOMPONENT-1234 --> JIRA ID: ROCM-32558 ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> - Run collector tests. - Validate JAX sampling and PyTorch cold-cache training on MI350X. - Check clean exit, cleanup and ISA output. ## Test Result <!-- Briefly summarize test outcomes. --> - All 68 PC sampling collector tests passed, including the new test for this bug. - JAX and PyTorch validation passed. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Prevent JAX/PyTorch PC sampling finalization failures when GPU addresses are reused.
Technical Details
Issue Tracking
JIRA ID: ROCM-32558
Test Plan
Test Result
Submission Checklist