Repository navigation
fix(rccl): compile rccl_arch_thresholds.cc into topo_expl once - #13706
Merged
alex-breslow-amd merged 2 commits intoOct 20, 2026
Merged
Conversation
#13466 and #12336 each fixed the missing rcclGetArchThresholds() link in topo_expl: the first through a hipified copy (hipify_rccl/), the second by compiling ../../src/rccl_arch_thresholds.cc directly. With both merged the file is compiled twice and the link fails with a duplicate symbol, which has kept math-ci extra(rccl) red on develop since 09d8fb1. Keep the hipified copy, matching rccl_wrap.cc and the other staged sources, and drop the direct entry. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
![amd-argus[bot]](https://avatars.githubusercontent.com/in/4740020?s=60&v=4){kind=small}
Kapil-Shyam-Pawar
approved these changes
Oct 19, 2026
alex-breslow-amd
deleted the
users/dondai/rccl-topo-expl-dup-arch-thresholds
branch
October 20, 2026 18:20
This was referenced Oct 21, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mci/rocm-libraries/extra(rccl)has failed ondevelopsince build #592 (09d8fb17ac), and on every PR that runs it. Thetopo_expllink fails with:Technical Details
Two PRs that merged on Oct 16 fixed the same missing
rcclGetArchThresholds()link intopo_expl:e45bca41bc) copiesrccl_arch_thresholds.ccintohipify_rccl/and compiles the hipified copy.09d8fb17ac) adds../../src/rccl_arch_thresholds.cctoRCCL_FILESdirectly.With both in place, the file is compiled twice. This PR keeps the hipified copy, which matches how
rccl_wrap.ccand the other staged sources are handled, and removes the direct entry. The comment from #12336 that explains why the file is needed still applies.Issue Tracking
N/A (CI break on
develop).Test Plan
Ran Jenkins' build step (serial
makeintools/topo_expl) on an MI300X node with ROCm 7.2, once on unmodifieddevelop(b8d1009e44) and once with this change. Then ran the built binary the way the CI test step does (./topo_explwith no arguments), plus two topology models.Test Result
develop:makefails with the duplicatercclGetArchThresholdssymbol shown above (rc 2), the same error as math-ci.topo_expllinks../topo_expl,./topo_expl -m 0and./topo_expl -m 54(4x gfx942) all exit 0 and finish generating the topology.Submission Checklist