Repository navigation
dev(hrr): add a local Docker runner for the test suites - #13620
Merged
Merged
Conversation
hrr_dev.py builds an image when it is missing and runs the host unit suite plus the integration drivers, under rocJitsu or on local GPUs.
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
andraghetti
reviewed
Oct 16, 2026
andraghetti
left a comment
andraghetti
left a comment
Contributor
There was a problem hiding this comment.
Useful tool. Five points inline; the first three make the default runs fail or leak a token.
Drop the missing handler config, export the capture amdhip64 in emulator mode, pass the token by name, set HOME for the non-root user, and build gpu mode for the detected arch. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Daniel Olsson <Daniel.Olsson@amd.com>
…ielbolsson/hrr-local-dev-20c1
With HOME=/tmp and a non-root uid, pip installs rocm[devel] to /tmp/.local, so rocm-sdk was not found and the script stopped there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Daniel Olsson <daniel.olsson@amd.com>
The container sets only ROCM_PATH, so detect_archs could not find the SDK's amdgpu-arch or rocminfo. An empty list then configured the build with no GPU target. Point ROCM_SDK at the SDK and stop on an empty list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Daniel Olsson <daniel.olsson@amd.com>
…OCm/rocm-systems into fix-13620-comments
andraghetti
approved these changes
Oct 19, 2026
andraghetti
left a comment
andraghetti
left a comment
Contributor
There was a problem hiding this comment.
All five points are fixed, and the MI350 gate on 222f148 is green.
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hrr_dev.py builds an image when it is missing and runs the host unit suite plus the integration drivers, under rocJitsu or on local GPUs.
Motivation
Technical Details
Issue Tracking
JIRA ID : AIRUNTIME-2947
Test Plan
Test Result
Submission Checklist
Motivation
Running the HRR host unit suite and the capture/replay integration drivers locally should not require a ROCm or rocJitsu install on the workstation.
hrr_dev.pybuilds an image when it is missing and runs the host unit suite plus the integration drivers, under rocJitsu or on local GPUs. The host only needs Docker.This is a development tool. It is separate from the HRR CI workflow in #13256.
Technical Details
Every changed file is under
projects/hrr.projects/hrr/tests/scripts/hrr_dev.pyis the command you run on the host.python3 projects/hrr/tests/scripts/hrr_dev.py emulatorpython3 projects/hrr/tests/scripts/hrr_dev.py gpuhrr-dev, container namehrr-dev. A missing image is built fromprojects/hrr/tests/docker/Dockerfile. A missing container is created. A stopped container is started, not recreated.rocm[devel]==10.1.0a20260822from the ROCm nightly index, builds the host unit suite withHRR_BUILD_INTEGRATION_TESTS=OFF, builds CLR with-DHIP_HRR_CAPTURE_ENABLED, and builds the integration suite forgfx950andgfx1250.emulatoralso builds the rocJitsu CLI and runs the integration drivers underrocjitsu --daemonwithemulation/rocjitsu/configs/gfx950_mi355x_kmd_2gpu.json(two GPUs) andemulation/rocjitsu/configs/gfx1250_mi455x_kmd_4gpu.json(four GPUs). One family failing still runs the other.gpupasses--device /dev/kfd,--device /dev/dri, and--group-add video, and runs the same integration binary with--arch auto.projects/hrr/tests/docker/Dockerfilestarts from the TheRock manylinux build image and adds PyYAML, the GitHub CLI, and GCC 13.run_catch2.pygains--launcher. Case listing still executeshrr-integration-testsdirectly. The launcher prefixes only the suite process, which is how the emulator command wraps rocJitsu.projects/hrr/tests/README.mdpoints at the two commands.Issue Tracking
JIRA ID : AIRUNTIME-2947
Test Plan
projects/hrr/tests/scripts:python3 -m unittest test_hrr_dev.py test_run_catch2.py. These do not start Docker.python3 projects/hrr/tests/scripts/hrr_dev.py emulator./dev/kfd:python3 projects/hrr/tests/scripts/hrr_dev.py gpu.Test Result
On
921a5db92f,test_hrr_dev.pyandtest_run_catch2.py: 31 passed. The image was not built, and the suites were not run inside a container.Submission Checklist