Repository navigation
fix(clr): set correlation id on hipEventRecord markers - #13617
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
hipEventRecord enqueues its EventMarker without batch flush, so Command::enqueue() never calls EnableProfiling() and the correlation id cleared in the EventMarker constructor stays 0. Every event-record barrier was then attributed to record 0 and drawn on stream-less lanes in the CLR profiler trace. Capture the current API's correlation id in the constructor.
saleelk
force-pushed
the
users/saleelk/FixEventCid
branch
from
October 19, 2026 06:23
3876f24 to
053d021
Compare
Contributor
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
gandryey
approved these changes
Oct 19, 2026
systems-assistant Bot
pushed a commit
to ROCm/clr
that referenced
this pull request
Oct 21, 2026
(#13617) hipEventRecord enqueues its EventMarker without batch flush, so Command::enqueue() never calls EnableProfiling() and the correlation id cleared in the EventMarker constructor stays 0. Every event-record barrier was then attributed to record 0 and drawn on stream-less lanes in the CLR profiler trace. Capture the current API's correlation id in the constructor. ## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> ## Issue Tracking <!-- Include a GitHub Issue and/or JIRA ID. Do not post any full JIRA links here. --> <!-- GitHub issue: ROCm/rocm-systems#1234 --> JIRA ID: AIRUNTIME-0 ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. [rocm-systems] ROCm/rocm-systems#13617 (commit 25c7cab)
dgaliffiAMD
pushed a commit
that referenced
this pull request
Oct 21, 2026
hipEventRecord enqueues its EventMarker without batch flush, so Command::enqueue() never calls EnableProfiling() and the correlation id cleared in the EventMarker constructor stays 0. Every event-record barrier was then attributed to record 0 and drawn on stream-less lanes in the CLR profiler trace. Capture the current API's correlation id in the constructor. ## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> ## Issue Tracking <!-- Include a GitHub Issue and/or JIRA ID. Do not post any full JIRA links here. --> <!-- GitHub issue: #1234 --> JIRA ID: AIRUNTIME-0 ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hipEventRecord enqueues its EventMarker without batch flush, so Command::enqueue() never calls EnableProfiling() and the correlation id cleared in the EventMarker constructor stays 0. Every event-record barrier was then attributed to record 0 and drawn on stream-less lanes in the CLR profiler trace. Capture the current API's correlation id in the constructor.
Motivation
Technical Details
Issue Tracking
JIRA ID: AIRUNTIME-0
Test Plan
Test Result
Submission Checklist