Repository navigation
Add backoff to hostcall timeout - #13599
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
There was a problem hiding this comment.
🟢 Approval recommended
The localized backoff is bounded, preserves signal and termination handling, and has no identified blocking issues.
0 open findings
What changed in this PR
Adds bounded timeout backoff to the new hostcall listener, reducing polling during inactivity.
Changes:
- Doubles the timeout after idle waits, capped at the legacy implementation’s maximum.
- Resets the timeout when activity resumes or the signal changes.
| File | Description |
|---|---|
| projects/clr/rocclr/device/devhostcall.cpp | Adds timeout bounds, idle backoff, and activity resets. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
|
I think it is pretty sad that this change, which is not being compiled in since the new implementation is not being enabled, is still seeing failing check. |
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
TheRock Submodule Bump ActivityNewest first
|
Motivation
The new hostcall implementation had a short timeout. This patch allows it to increase when there is no activity.
Technical Details
Adds a simple doubling scheme to the timeout to a maximum that matches the original hostcall implementation.
Test Plan
Benchmarks and other hostcall tests.
Test Result
All tests passed
Submission Checklist