Repository navigation
Feat(hipfile) Aischeck now accepts md raid partitions properly - #13473
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Kernel-dependent RAID eligibility requires validation against supported drivers and hardware beyond the supplied topology tests.
0 open findings
What changed in this PR
Updates hipFile’s ais-check to recognize supported MD RAID stacks on local NVMe devices.
Changes:
- Accepts supported MD RAID arrays and partitions while rejecting parity RAID layers.
- Adds topology and device-mapper parsing tests.
- Updates capability diagnostics and release notes.
| File | Description |
|---|---|
| projects/hipfile/tools/ais-check/tests/test_volumes.py | Tests MD/LVM stacks, partitions, and RAID classification. |
| projects/hipfile/tools/ais-check/ais-check | Implements MD traversal and RAID eligibility checks. |
| projects/hipfile/test/common/ais-capability.h | Clarifies unsupported-storage comments. |
| projects/hipfile/test/common/ais-capability.cpp | Updates unsupported-storage diagnostics. |
| projects/hipfile/CHANGELOG.md | Documents MD support and parity RAID rejection. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
spolifroni-amd
approved these changes
Oct 14, 2026
riley-dixon
reviewed
Oct 14, 2026
gaoikawa
approved these changes
Oct 14, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
pmoutsias-amd
added a commit
that referenced
this pull request
Nov 5, 2026
…branch to the (Unreleased) hipFile 0.7.0 section (#14918) These 4 CHANGELOG entries sit in release sections, but the code was merged to develop after the `rocm-systems` commit that TheRock `release/therock-10.2` pins (`ded49fd`), and is not in that commit. This moves them into `## (Unreleased) hipFile 0.7.0`, under the matching subsections. - #13473 (merged 2026-10-15, and its merge commit is not in `ded49fd`), moved from the `hipFile 0.6.0 for ROCm 10.2.0` section: > * MD and LVM software RAID arrays running pass-through personalities whose member devices are all local NVMe are now fastpath capable, and `ais-check` reports them as such. - #13473 (merged 2026-10-15, and its merge commit is not in `ded49fd`), moved from the `hipFile 0.6.0 for ROCm 10.2.0` section: > * `ais-check` no longer reports an LVM parity RAID logical volume (`raid4`, `raid5`, `raid6`) as fastpath capable. - #13657 (merged 2026-10-16, and its merge commit is not in `ded49fd`), moved from the `hipFile 0.6.0 for ROCm 10.2.0` section: > * Per-GPU I/O statistics are now attributed to the GPU that owns the I/O buffer instead of the caller's active HIP device. Previously, `hipFileGetStatsL3()` and `ais-stats` could report counters against the wrong GPU when the active device differed from the buffer's device. - #13862 (merged 2026-10-21, and its merge commit is not in `ded49fd`), moved from the `hipFile 0.6.0 for ROCm 10.2.0` section: > * `hipfile.h` now includes `<time.h>`, which declares the `struct timespec` used by `hipFileBatchIOGetStatus()`. Previously, C code that included `<time.h>` after `hipfile.h` got an incompatible pointer type error or warning when passing a `struct timespec *` to `hipFileBatchIOGetStatus()`. Only the CHANGELOG is changed. Version macros are left to the component owners. JIRA ID : AIROCDOC-4467
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Kfd changes allow fast path for md raid on hipfile
Technical Details
ais-check tool explores md raid files as acceptable
Issue Tracking
JIRA ID : AIHIPFILE-280
Test Plan
Part of CI
Test Result
Submission Checklist