Skip to content

build(rocr): Bump runtime version to 1.22.0 - #13462

Merged
lamikr merged 1 commit into
developfrom
users/dayatsin/rocr-1.22.0
Oct 21, 2026
Merged

lamikr merged 1 commit into
developfrom
users/dayatsin/rocr-1.22.0

Conversation

@dayatsin-amd

@dayatsin-amd dayatsin-amd commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Bump the ROCr runtime package version from 1.21.0 to 1.22.0 in projects/rocr-runtime/CMakeLists.txt. This is the version get_version() publishes as the shared-library and package version.

ROCr changes since 1.21.0 (ROCm 10.1.0, therock-10.1) through the 10.2 snapshot release/bkc/therock-10.2-20261013. The AMD extension interface is minor 34.

New APIs

  • GL2 residency control. hsa_amd_agent_set_attribute with HSA_AMD_AGENT_ATTRIBUTE_REQUEST_PERSISTING_L2_CACHE_SIZE, plus agent queries HSA_AMD_AGENT_INFO_REQUEST_PERSISTING_L2_CACHE_SIZE and HSA_AMD_AGENT_INFO_MAX_PERSISTING_L2_CACHE_SIZE. The DXG thunk exports hsaKmtSetPersistingCacheSize so the same path works under WSL.
  • VMM handle info. hsa_amd_vmem_get_vmem_info reports placement and size for both local handles and imported shareable handles. Imported host-backed VMM reports its real placement and size.
  • Execute permission is its own bit. HSA_ACCESS_PERMISSION_EX can be combined with read/write. VMM maps pass AMDGPU_VM_PAGE_EXECUTABLE when that bit is set.
  • AIE pointer info includes the device address of an allocation, so a full-ELF dispatch can patch control scratchpads and extra configuration buffers. Releasing AIE memory leaves that mapping in place.

Memory and SVM

  • SVM host access is granted only to the GPUs that map the range. A range that is registered but never mapped is not revoked.
  • SVM host revoke runs on a worker thread when HSA_SVM_HOST_UNREGISTER_DEBUG is set, so unregister returns without waiting for the ioctl. A later register waits only if its range overlaps an in-flight revoke.
  • Host VMM chooses the DRM agent in ROCr and tells the thunk which node to use, so the GTT allocation and the following DRM import stay on the same device. hsa_amd_vmem_set_access on a CPU agent works for handles imported from another process.
  • Userptr GPU virtual addresses come out of the system heap. IPC/system-heap reservation shrinks (1×, ½, ¼ of system RAM, floor 8 GB) when the address space is tight, and a failed reservation returns out-of-memory.
  • Single-NUMA machines return success immediately from bind_mem_to_numa.

ISA, sampling, and queues

  • gfx1170 and gfx1171 (ISA 11.7.x): ISA and ELF ids, blit kernels, addrlib, and the gfx11-7-generic fatbin fallback.
  • gfx125x kernels report wavefront size 32 from the ISA registry.
  • Host-trap PC sampling on gfx12.0 keeps samples. The buffer selector stays stable across an explicit flush, and host buffers are sized to a whole number of samples.
  • Thunk loading is split into Linux and Windows files, and host fences and pause are portable across x86, ARM, RISC-V, and POWER.

JIRA ID

JIRA ID :

Test plan

  • Confirmed get_version("1.22.0") is the only 1.21.0 reference under projects/rocr-runtime on develop
  • Package build reports version 1.22.0

@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

The 1.22.0 package version covers the ROCr changes since 1.21.0.

Co-authored-by: Cursor <cursoragent@cursor.com>
@dayatsin-amd
dayatsin-amd force-pushed the users/dayatsin/rocr-1.22.0 branch from 38e296f to 57e179a Compare October 14, 2026 15:14
@dayatsin-amd

Copy link
Copy Markdown
Contributor Author

CI failure analysis

The diff only changes get_version("1.21.0") to get_version("1.22.0") in projects/rocr-runtime/CMakeLists.txt. The test failures on run 38587632684 are not caused by that change. Multi-Arch CI Summary failed only because these jobs failed.

Linux gfx94X setup (HTTP 429)

These jobs died in Run setup test environment workflow before any test ran. GitHub returned HTTP 429 while fetching the repo, then python: command not found (exit 127):

  • hip-tests (shard 4/4), hipblas, hipblasltprovider, origami, rocsolver (shard 1/3), rocrand, rocgdb-gpu, rocwmma (shard 1/5), aqlprofile

Linux gfx94X tests that actually ran

These are other components, and the failures are GPU/runtime aborts, not a package version string:

  • rocprofiler-sdk: rocprofv3-test-att-no-intercept subprocess aborted (thread-trace). 2 of 1859 tests failed.
  • miopenprovider: miopen-provider-external-integration_standard_suite aborted with HW Exception by GPU node-5 ... GPU Hang during a convolution sweep.
  • rocprofiler-compute: test_profile_misc subprocess aborted. 1 of 82 tests failed.

Windows gfx110X

Self-hosted runner lost communication during setup. No test step ran:

  • hipblas, rocblas (shard 2/6), rocblas (shard 5/6)

Related check

therock-pr-bot is the one failure that belongs to this PR: the description has an empty JIRA ID : line, so the bot reports no valid JIRA/ISSUE/closing-keyword reference. That does not affect the runtime build.

@lamikr

lamikr commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Merging., all tests passed now (except pr bot).

@lamikr
lamikr merged commit e790e3f into develop Oct 21, 2026
390 of 407 checks passed
@lamikr
lamikr deleted the users/dayatsin/rocr-1.22.0 branch October 21, 2026 17:18
systems-assistant Bot pushed a commit to ROCm/ROCR-Runtime that referenced this pull request Oct 21, 2026
The 1.22.0 package version covers the ROCr changes since 1.21.0.

Co-authored-by: Cursor <cursoragent@cursor.com>
[rocm-systems] ROCm/rocm-systems#13462 (commit e790e3f)
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants