Repository navigation
Conversation
1 task done
github-actions
Bot
added
the
github actions
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The workflow omits its source-level CMake configuration from the PR path filters.
1 open finding
What changed in this PR
Adds CI coverage for RCCL’s OpenSSL 3 TLS backend and schedules weekly TLS validation.
Changes:
- Adds a CPU-only TLS compilation workflow.
- Registers the weekly Ruby TLS Coco job.
- Updates weekly matrix expectations.
| File | Description |
|---|---|
.github/workflows/rccl-tls-build.yml |
Adds targeted TLS compilation CI. |
.github/scripts/rccl_coco_matrix.py |
Adds the weekly TLS job. |
.github/scripts/tests/rccl_coco_matrix_test.py |
Updates weekly job assertions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Doesn't CoCo build RCCL? I think this could be fully in CoCo, but I'm not sure. |
Adds ruby64-rccl-tls-weekly (ROCm/tRCCL#612) to the scheduled catalogue. The job builds RCCL with -DTLS_BACKEND=OPENSSL3 and runs the socket encryption gtests and encrypted rccl-tests.
i-kosarev
force-pushed
the
users/ilkosare/rccl-tls-ci
branch
from
November 6, 2026 19:07
f836625 to
97c7ac0
Compare
i-kosarev
changed the title
Contributor
Author
Agreed, dropped the TLS build guard. This PR now only schedules the coco TLS weekly job. |
Contributor
pr-rocm-systems-13373-oci-rccl-pr-smokeBuilds
FailuresNo failing tests in this run. 15 tests skipped. Performance regressions
|
Contributor
pr-rocm-systems-13373-ruby64-rccl-pr-smokeBuilds
FailuresNo failing tests in this run. 15 tests skipped. Performance regressions
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
No scheduled coco run builds RCCL with
TLS_BACKEND=OPENSSL3, so socket encryption is never tested.Technical Details
.github/scripts/rccl_coco_matrix.py: schedules the weekly coco jobruby64-rccl-tls-weekly(ROCm/tRCCL#612). The job builds RCCL with-DTLS_BACKEND=OPENSSL3and runs the socket encryption gtests and encrypted rccl-tests.Merge after #13368, #13369 and ROCm/tRCCL#612.
Issue Tracking
JIRA ID: AICOMRCCL-2488
Test Plan
coco matrix script tests.
Test Result
Matrix script tests pass.
Submission Checklist