Skip to content

test(rccl): add host microtests for nccl_device/utility.h math helpers #13315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduforest wants to merge 6 commits into from
Closed

test(rccl): add host microtests for nccl_device/utility.h math helpers #13315

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f81f407
test(rccl): add host microtests for nccl_device/utility.h math helpers
aduforest Oct 12, 2026
0677547
test(rccl): address ARGUS findings on utility.h microtests
aduforest Oct 13, 2026
47a1255
test(rccl): pin alignUp's - 1, rollingLessThan's nBits forward, trim …
aduforest Oct 13, 2026
d1eb14c
test(rccl): correct the imulRcp32 counterexample comment, note the bi…
aduforest Oct 13, 2026
87d7310
test(rccl): pin alignDown's negation, rollingLessEq's half-range boun…
aduforest Oct 14, 2026
f41e1d5
test(rccl): trim microtest docs and comments to match the other host …
aduforest Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/rccl/test/host/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ function(rccl_define_micro_source_lists)
devcomm-test.cc
wrap-test.cc
dev-runtime-test.cc
nccl-utility-test.cc # src/include/nccl_device/utility.h (header-only, no fakes)
# sym-kernels-index-test.cc: added conditionally below, only when GENERATE_SYM_KERNELS is ON.
gdr-probe-test.cc # src/misc/gdr_probe.cc runtime GDR registration probe
process-isolated-runner-test.cc
Expand Down
8 changes: 8 additions & 0 deletions projects/rccl/test/host/MICROTEST_README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ export colliding non-`static` symbols; otherwise a unit needs its own binary:
- `dev_runtime.cc` (`DEV_RUNTIME_CC_PATH`, from `dev-runtime-test.cc`);
suites `Alloc*`, `Comm*`, `Compute*`, `DeepCopy*`, `Dev*`, `Gin*`, `Nccl*`,
`Sym*`, and `Win*`.
- `src/include/nccl_device/utility.h` (header-only, from
`nccl-utility-test.cc`); suite `NcclUtilityMicrotest.*` (also caught by the
`Nccl*` pattern above). No `_CC_PATH` macro needed since it's a header,
not a `.cc` production TU, and no fakes since every targeted function
compiles cleanly in a host-only TU -- most are `NCCL_HOST_DEVICE_INLINE`
pure math with no HIP dependency; the four `memory_order` conversion
helpers sit inside `#if NCCL_CHECK_CUDACC`, which this build satisfies
because this target's `--offload-host-only` build still invokes hipcc.
- the generated `sym_kernels_host.cc` (`SYM_KERNELS_HOST_CC_PATH`, from
`sym-kernels-index-test.cc`); suites `SymKernelIndex*`,
`SymAllEmittedCombinations/*`, `SymUnhandledCombinations/*` (covered by the
Expand Down
Loading
Loading