Repository navigation
fix(rocprofiler-sdk): handle HSA execute permissions in formatter - #13286
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The formatter handles all valid permission combinations while remaining compatible with older HSA headers.
0 open findings
What changed in this PR
Updates rocprofiler-sdk’s HSA permission formatter for newer ROCr headers while retaining compatibility with older headers.
Changes:
- Formats execute permission and all read/write combinations.
- Reports unsupported bitmasks as
UNKNOWN.
| File | Description |
|---|---|
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hsa/utils.hpp |
Adds execute-bit formatting through an integer bitmask switch. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MythreyaK
approved these changes
Oct 12, 2026
sauverma93
approved these changes
Oct 12, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/ROCm/rocm-systems/actions/runs/38259799910/job/114847245719?pr=12889
ROCr PR #13129 added HSA_ACCESS_PERMISSION_EX to hsa_access_permission_t. The rocprofiler-sdk permission formatter does not handle this value, causing builds with newer HSA headers to fail when warnings are treated as errors:
Technical Details
Update the HSA access-permission formatter to:
Issue Tracking
Test Plan
CI passes.
Test Result
Submission Checklist