Skip to content

[rocdbgapi] do minor refactoring - #13178

Merged
aktemur merged 2 commits into
developfrom
users/aktemur/rocdbgapi/minor-refactoring
Oct 12, 2026
Merged

[rocdbgapi] do minor refactoring#13178
aktemur merged 2 commits into
developfrom
users/aktemur/rocdbgapi/minor-refactoring

Conversation

@aktemur

@aktemur aktemur commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Motivation

Small code maintenance.

aktemur added 2 commits October 9, 2026 13:29
@aktemur
refactor(rocdbgapi): shorten a train call
a7c5a85 
Instead of accessing the cluster of a wave via its workgroup, access
it over the wave itself.  This is a simple refactoring.
@aktemur
fix(rocdbgapi): update a comment about pruning objects
60c8055 
Now that we have clusters in the hierarchy, a comment about pruning
objects is slightly outdated.  Update the comment.
@aktemur
aktemur requested a review from a team as a code owner October 9, 2026 11:33
@therock-pr-bot

therock-pr-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocdbgapi/src/queue.cpp; no test file found
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@aktemur
aktemur merged commit e25671b into develop Oct 12, 2026
147 of 157 checks passed
@aktemur
aktemur deleted the users/aktemur/rocdbgapi/minor-refactoring branch October 12, 2026 10:32
systems-assistant Bot pushed a commit to ROCm/ROCdbgapi that referenced this pull request Oct 12, 2026
@aktemur @systems-assistant
fix(rocdbgapi): update a comment about pruning objects
ff158a2 
Now that we have clusters in the hierarchy, a comment about pruning
objects is slightly outdated.  Update the comment.
[rocm-systems] ROCm/rocm-systems#13178 (commit e25671b)
@systems-assistant

systems-assistant Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lancesix lancesix lancesix approved these changes

Assignees

No one assigned

Labels

Not ready to Review organization: ROCm project: rocdbgapi

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aktemur @lancesix