Skip to content

fix(clr): move to cxxheaderparser - #13176

Merged
litvaOo merged 1 commit into
developfrom
users/jatin/cxxheaderparser
Oct 26, 2026
Merged

litvaOo merged 1 commit into
developfrom
users/jatin/cxxheaderparser

Conversation

@cjatin

@cjatin cjatin commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Motivation

cppheaderparser is deprecated, we should move to cxxheaderparser. We had a pr for it before the move to TheRock happened.
Trying to revive this.

Technical Details

use cxxheaderparser instead of cppheaderparser.

This depends on ROCm/TheRock#8887

Issue Tracking

JIRA-ID: ROCM-22685

Test Plan

Build should work fine.

Test Result

Awaiting build results.

Submission Checklist

Co-Authored-By: Claude Opus 5noreply@anthropic.com

Copilot AI balanced review requested due to automatic review settings October 9, 2026 11:07
@cjatin
cjatin requested review from a team as code owners October 9, 2026 11:07
@therock-pr-bot

therock-pr-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/clr/hipamd/src/hip_prof_gen.py; no test file found
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The migration consistently updates parsing, build checks, and documentation without identified correctness issues.

0 open findings

What changed in this PR

Migrates CLR profiling-header generation from deprecated CppHeaderParser to cxxheaderparser.

Changes:

  • Adds preprocessing cleanup and enum-value extraction.
  • Updates dependency checks and installation documentation.
File Description
projects/​clr/​README.md Updates the Python prerequisite.
projects/​clr/​hipamd/​src/​hip_prof_gen.py Migrates parsing and enum extraction.
projects/​clr/​hipamd/​src/​CMakeLists.txt Checks for the new package.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mangupta mangupta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI-assisted pre-review (for @mangupta)

Comment thread projects/clr/hipamd/src/hip_prof_gen.py Resolved
@cjatin
cjatin force-pushed the users/jatin/cxxheaderparser branch 2 times, most recently from 05d3a7f to b11d953 Compare October 12, 2026 10:39
@mangupta

Copy link
Copy Markdown
Contributor

🤖 AI-assisted pre-review (for @mangupta)

Re-reviewed the updated head (b11d95369773) — no new findings at or above the posting threshold.

@cjatin
cjatin force-pushed the users/jatin/cxxheaderparser branch from b11d953 to a7ac0f2 Compare October 13, 2026 09:05
@mangupta

Copy link
Copy Markdown
Contributor

🤖 AI-assisted pre-review (for @mangupta)

Re-reviewed the updated head (a7ac0f27832a) — no new findings at or above the posting threshold.

@cjatin
cjatin force-pushed the users/jatin/cxxheaderparser branch 3 times, most recently from 1e7c104 to d6fc8af Compare October 19, 2026 22:09

@litvaOo litvaOo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMakeLists.txt LGTM

@cjatin
cjatin force-pushed the users/jatin/cxxheaderparser branch from d6fc8af to 2a66676 Compare October 21, 2026 09:04
@litvaOo
litvaOo force-pushed the users/jatin/cxxheaderparser branch from 2a66676 to 224c9b2 Compare October 22, 2026 08:33
@litvaOo

litvaOo commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Rocprofiler-sdk errors are unrelated to PR changes, overriding.

@litvaOo
litvaOo merged commit fd42f7f into develop Oct 26, 2026
403 of 414 checks passed
@litvaOo
litvaOo deleted the users/jatin/cxxheaderparser branch October 26, 2026 10:08
systems-assistant Bot pushed a commit to ROCm/clr that referenced this pull request Oct 26, 2026
## Motivation

cppheaderparser is deprecated, we should move to cxxheaderparser. We had
a pr for it before the move to TheRock happened.
Trying to revive this.

## Technical Details

use cxxheaderparser instead of cppheaderparser.

This depends on ROCm/TheRock#8887

## Issue Tracking

JIRA-ID: ROCM-22685

## Test Plan

Build should work fine.

## Test Result

Awaiting build results.

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

Co-Authored-By: Claude Opus 5<noreply@anthropic.com>
[rocm-systems] ROCm/rocm-systems#13176 (commit fd42f7f)
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants