Repository navigation
fix(clr): move to cxxheaderparser - #13176
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
There was a problem hiding this comment.
🟢 Approval recommended
The migration consistently updates parsing, build checks, and documentation without identified correctness issues.
0 open findings
What changed in this PR
Migrates CLR profiling-header generation from deprecated CppHeaderParser to cxxheaderparser.
Changes:
- Adds preprocessing cleanup and enum-value extraction.
- Updates dependency checks and installation documentation.
| File | Description |
|---|---|
projects/clr/README.md |
Updates the Python prerequisite. |
projects/clr/hipamd/src/hip_prof_gen.py |
Migrates parsing and enum extraction. |
projects/clr/hipamd/src/CMakeLists.txt |
Checks for the new package. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
05d3a7f to
b11d953
Compare
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
b11d953 to
a7ac0f2
Compare
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
1e7c104 to
d6fc8af
Compare
d6fc8af to
2a66676
Compare
2a66676 to
224c9b2
Compare
|
Rocprofiler-sdk errors are unrelated to PR changes, overriding. |
## Motivation cppheaderparser is deprecated, we should move to cxxheaderparser. We had a pr for it before the move to TheRock happened. Trying to revive this. ## Technical Details use cxxheaderparser instead of cppheaderparser. This depends on ROCm/TheRock#8887 ## Issue Tracking JIRA-ID: ROCM-22685 ## Test Plan Build should work fine. ## Test Result Awaiting build results. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. Co-Authored-By: Claude Opus 5<noreply@anthropic.com> [rocm-systems] ROCm/rocm-systems#13176 (commit fd42f7f)
TheRock Submodule Bump ActivityNewest first
|
Motivation
cppheaderparser is deprecated, we should move to cxxheaderparser. We had a pr for it before the move to TheRock happened.
Trying to revive this.
Technical Details
use cxxheaderparser instead of cppheaderparser.
This depends on ROCm/TheRock#8887
Issue Tracking
JIRA-ID: ROCM-22685
Test Plan
Build should work fine.
Test Result
Awaiting build results.
Submission Checklist
Co-Authored-By: Claude Opus 5noreply@anthropic.com