Repository navigation
[rocjitsu][amdisa][add-atomic 4/5] Add s_atomic_cmpswap* instructions - #13142
Merged
Merged
Conversation
github-actions
Bot
added
documentation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
accauble
force-pushed
the
users/accauble/rj-s-atomic-cmpswap
branch
2 times, most recently
from
October 20, 2026 19:58
28cb7c0 to
e1944ab
Compare
accauble
force-pushed
the
users/accauble/rj-s-atomic-cmpswap
branch
from
October 20, 2026 20:39
e1944ab to
7d93070
Compare
accauble
marked this pull request as ready for review
October 20, 2026 20:43
kuhar
approved these changes
Oct 20, 2026
kuhar
left a comment
kuhar
left a comment
Member
There was a problem hiding this comment.
LGTM
It would be useful to extend the compare-swap tests with a few of the neighboring scalar-atomic checks (optional coverage improvements):
- In
emulation/rocjitsu/tests/scalar_atomic_test.cpp:307, includesourcein the trace and seed/check SCC and check EXEC, so failures show both input operands and the new operation also checks preservation of wave state. - At
emulation/rocjitsu/tests/scalar_atomic_test.cpp:576, checklgkmcnt == dwordsafter the unavailable tick and exercise both GLC values, checking that GLC=0 preserves SDATA after the lost exchange. This would cover pending-counter retention and suppressed writeback on that retry path.
kuhar
force-pushed
the
users/accauble/rj-s-atomic-cmpswap
branch
2 times, most recently
from
October 21, 2026 10:49
1222617 to
a64fe16
Compare
Base automatically changed from
users/accauble/rj-s-atomic-int-ops
to
develop
October 21, 2026 11:10
* These instructions are slightly different since it can use data from double the registers (one for compare, one for source).
kuhar
force-pushed
the
users/accauble/rj-s-atomic-cmpswap
branch
from
October 21, 2026 11:10
a64fe16 to
4484cb4
Compare
Contributor
TheRock Submodule Bump ActivityNewest first
|
49 of 57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds the
s_atomic_cmpswap*instructions, which needed to be treated differently since they use data from double the registers (one for compare, one for source).Issue Tracking
Part of Issue #13025