Skip to content

feat(ci): bump TheRock hash to 05add19 (2026-10-08) - #13132

Merged
geomin12 merged 1 commit into
developfrom
users/geomin12/bump-hash-05add19
Oct 8, 2026
Merged

feat(ci): bump TheRock hash to 05add19 (2026-10-08)#13132
geomin12 merged 1 commit into
developfrom
users/geomin12/bump-hash-05add19

Conversation

@geomin12

@geomin12 geomin12 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

bump TheRock ref to 05add1 (2026-10-08)

Adding test_type from configure_external_ci as well to optimize CI work

@geomin12 @claude
build(ci): bump TheRock hash to 05add1921fd03b0649f054ec2a7c54d162c0cd99
70968ce 
Also adds test_type output from configure_external_repo_ci.py and
passes it to the linux/windows build jobs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12
geomin12 requested a review from a team as a code owner October 8, 2026 17:28
@github-actions github-actions Bot added the github actions Pull requests that update GitHub Actions code label Oct 8, 2026
@therock-pr-bot

therock-pr-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

dysu-amd
dysu-amd reviewed Oct 8, 2026
View reviewed changes
Comment thread .github/workflows/therock-multi-arch-ci.yml
test_labels: ${{ needs.setup.outputs.windows_test_labels }}
rocm_package_version: ${{ needs.setup.outputs.rocm_package_version }}
test_type: ${{ needs.setup.outputs.test_type }}
test_type: ${{ needs.configure.outputs.test_type }}

@dysu-amd dysu-amd Oct 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agent analysis says this will cause PR test filter labels like test_filter:comprehensive to have no effect, as those are parsed during setup in configure_multi_arch_ci.py

@dysu-amd dysu-amd Oct 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs.configure calls configure_external_repo_ci.py, which as far as i can tell doesn't check these labels?

@geomin12 geomin12 Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intended behavior! fixed with ROCm/TheRock#8800

@geomin12
geomin12 requested a review from dysu-amd October 8, 2026 18:28
@geomin12
geomin12 merged commit f8d222e into develop Oct 8, 2026
199 of 210 checks passed
@geomin12
geomin12 deleted the users/geomin12/bump-hash-05add19 branch October 8, 2026 22:10
@systems-assistant

systems-assistant Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

anujshuk-amd pushed a commit that referenced this pull request Oct 12, 2026
@geomin12 @claude @anujshuk-amd
feat(ci): bump TheRock hash to 05add19 (2026-10-08) (#13132)
28c4713 
bump TheRock ref to `05add1` (2026-10-08)

Adding test_type from `configure_external_ci` as well to optimize CI
work

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dysu-amd dysu-amd dysu-amd approved these changes

Assignees

No one assigned

Labels

github actions Pull requests that update GitHub Actions code Not ready to Review organization: ROCm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geomin12 @dysu-amd